From ade63dd7647dc0089925da7d2edc3c904fde7c42 Mon Sep 17 00:00:00 2001 From: Paco Xu Date: Wed, 22 Mar 2023 18:09:42 +0800 Subject: [PATCH] cronjob: add ut for namespace terminating cause no extra log --- .../cronjob/cronjob_controllerv2_test.go | 21 +++++++++++++++++++ 1 file changed, 21 insertions(+) diff --git a/pkg/controller/cronjob/cronjob_controllerv2_test.go b/pkg/controller/cronjob/cronjob_controllerv2_test.go index 507f0b722c8..3021ad87ace 100644 --- a/pkg/controller/cronjob/cronjob_controllerv2_test.go +++ b/pkg/controller/cronjob/cronjob_controllerv2_test.go @@ -18,6 +18,7 @@ package cronjob import ( "context" + "fmt" "reflect" "strings" "testing" @@ -1165,6 +1166,26 @@ func TestControllerV2SyncCronJob(t *testing.T) { expectUpdateStatus: true, jobPresentInCJActiveStatus: true, }, + "do nothing if the namespace is terminating": { + jobCreateError: &errors.StatusError{ErrStatus: metav1.Status{Details: &metav1.StatusDetails{Causes: []metav1.StatusCause{ + { + Type: v1.NamespaceTerminatingCause, + Message: fmt.Sprintf("namespace %s is being terminated", metav1.NamespaceDefault), + Field: "metadata.namespace", + }}}}}, + concurrencyPolicy: "Allow", + schedule: onTheHour, + deadline: noDead, + ranPreviously: true, + stillActive: true, + jobCreationTime: justAfterThePriorHour(), + now: *justAfterTheHour(), + expectActive: 0, + expectRequeueAfter: false, + expectUpdateStatus: false, + expectErr: true, + jobPresentInCJActiveStatus: false, + }, } for name, tc := range testCases { name := name