github/kubernetes
1
0
Fork 0
mirror of https://github.com/k3s-io/kubernetes.git synced 2025-07-20 18:31:15 +00:00
Code Issues Projects Releases Wiki Activity

gendocs: using bytes.NewReader(nil)/ioutil.Discard instead of os input/output to generate command

Browse Source
This commit is contained in:
SataQiu 2021-06-08 11:55:32 +08:00
parent 588d984407
commit aea2e33175
3 changed files with 8 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
cmd/gendocs/gen_kubectl_docs.go
View File

@ -17,6 +17,7 @@ limitations under the License.
package main package main
import ( import (
"bytes"
"fmt" "fmt"
"io/ioutil" "io/ioutil"
"os" "os"
@ -45,7 +46,6 @@ func main() {
// Set environment variables used by kubectl so the output is consistent, // Set environment variables used by kubectl so the output is consistent,
// regardless of where we run. // regardless of where we run.
os.Setenv("HOME", "/home/username") os.Setenv("HOME", "/home/username")
// TODO os.Stdin should really be something like ioutil.Discard, but a Reader kubectl := cmd.NewKubectlCommand(bytes.NewReader(nil), ioutil.Discard, ioutil.Discard)
kubectl := cmd.NewKubectlCommand(os.Stdin, ioutil.Discard, ioutil.Discard)
doc.GenMarkdownTree(kubectl, outDir) doc.GenMarkdownTree(kubectl, outDir)
} }

4
cmd/genkubedocs/gen_kube_docs.go
View File

@ -17,7 +17,9 @@ limitations under the License.
package main package main
import ( import (
"bytes"
"fmt" "fmt"
"io/ioutil"
"os" "os"
"github.com/spf13/cobra/doc" "github.com/spf13/cobra/doc"
@ -77,7 +79,7 @@ func main() {
pflag.CommandLine = pflag.NewFlagSet(os.Args[0], pflag.ExitOnError) pflag.CommandLine = pflag.NewFlagSet(os.Args[0], pflag.ExitOnError)
// generate docs for kubeadm // generate docs for kubeadm
kubeadm := kubeadmapp.NewKubeadmCommand(os.Stdin, os.Stdout, os.Stderr) kubeadm := kubeadmapp.NewKubeadmCommand(bytes.NewReader(nil), ioutil.Discard, ioutil.Discard)
doc.GenMarkdownTree(kubeadm, outDir) doc.GenMarkdownTree(kubeadm, outDir)
// cleanup generated code for usage as include in the website // cleanup generated code for usage as include in the website

7
cmd/genman/gen_kube_man.go
View File

@ -96,15 +96,14 @@ func main() {
} }
case "kubectl": case "kubectl":
// generate manpage for kubectl // generate manpage for kubectl
// TODO os.Stdin should really be something like ioutil.Discard, but a Reader kubectl := kubectlcmd.NewKubectlCommand(bytes.NewReader(nil), ioutil.Discard, ioutil.Discard)
kubectl := kubectlcmd.NewKubectlCommand(os.Stdin, ioutil.Discard, ioutil.Discard)
genMarkdown(kubectl, "", outDir) genMarkdown(kubectl, "", outDir)
for _, c := range kubectl.Commands() { for _, c := range kubectl.Commands() {
genMarkdown(c, "kubectl", outDir) genMarkdown(c, "kubectl", outDir)
} }
case "kubeadm": case "kubeadm":
// generate manpage for kubelet // generate manpage for kubeadm
kubeadm := kubeadmapp.NewKubeadmCommand(os.Stdin, os.Stdout, os.Stderr) kubeadm := kubeadmapp.NewKubeadmCommand(bytes.NewReader(nil), ioutil.Discard, ioutil.Discard)
genMarkdown(kubeadm, "", outDir) genMarkdown(kubeadm, "", outDir)
for _, c := range kubeadm.Commands() { for _, c := range kubeadm.Commands() {
genMarkdown(c, "kubeadm", outDir) genMarkdown(c, "kubeadm", outDir)