From 80471bf487cfca8fcbddb019accb7d22dabc0a9f Mon Sep 17 00:00:00 2001 From: Michelle Au Date: Mon, 29 Apr 2019 15:15:50 -0700 Subject: [PATCH] remove pd-external from e2e config Change-Id: I1d734fcc8e8145e586b5df9acd0736c7ba0658d1 --- test/e2e/storage/csi_volumes.go | 1 - test/e2e/storage/drivers/csi.go | 74 --------------------------------- 2 files changed, 75 deletions(-) diff --git a/test/e2e/storage/csi_volumes.go b/test/e2e/storage/csi_volumes.go index c50bb51b715..e3cebb088a0 100644 --- a/test/e2e/storage/csi_volumes.go +++ b/test/e2e/storage/csi_volumes.go @@ -35,7 +35,6 @@ import ( var csiTestDrivers = []func() testsuites.TestDriver{ drivers.InitHostPathCSIDriver, drivers.InitGcePDCSIDriver, - drivers.InitGcePDExternalCSIDriver, drivers.InitHostPathV0CSIDriver, // Don't run tests with mock driver (drivers.InitMockCSIDriver), it does not provide persistent storage. } diff --git a/test/e2e/storage/drivers/csi.go b/test/e2e/storage/drivers/csi.go index 473a1dca9d5..e9c03319d20 100644 --- a/test/e2e/storage/drivers/csi.go +++ b/test/e2e/storage/drivers/csi.go @@ -431,77 +431,3 @@ func (g *gcePDCSIDriver) PrepareTest(f *framework.Framework) (*testsuites.PerTes cancelLogging() } } - -// gcePd-external -type gcePDExternalCSIDriver struct { - driverInfo testsuites.DriverInfo -} - -var _ testsuites.TestDriver = &gcePDExternalCSIDriver{} -var _ testsuites.DynamicPVTestDriver = &gcePDExternalCSIDriver{} - -// InitGcePDExternalCSIDriver returns gcePDExternalCSIDriver that implements TestDriver interface -func InitGcePDExternalCSIDriver() testsuites.TestDriver { - return &gcePDExternalCSIDriver{ - driverInfo: testsuites.DriverInfo{ - Name: GCEPDCSIProvisionerName, - // TODO(#70258): this is temporary until we can figure out how to make e2e tests a library - FeatureTag: "[Feature: gcePD-external]", - MaxFileSize: testpatterns.FileSizeMedium, - SupportedFsType: sets.NewString( - "", // Default fsType - "ext2", - "ext3", - "ext4", - "xfs", - ), - Capabilities: map[testsuites.Capability]bool{ - testsuites.CapPersistence: true, - testsuites.CapFsGroup: true, - testsuites.CapExec: true, - testsuites.CapMultiPODs: true, - }, - }, - } -} - -func (g *gcePDExternalCSIDriver) GetDriverInfo() *testsuites.DriverInfo { - return &g.driverInfo -} - -func (g *gcePDExternalCSIDriver) SkipUnsupportedTest(pattern testpatterns.TestPattern) { - framework.SkipUnlessProviderIs("gce", "gke") - if pattern.FsType == "xfs" { - framework.SkipUnlessNodeOSDistroIs("ubuntu", "custom") - } - if pattern.FeatureTag == "[sig-windows]" { - framework.Skipf("Skipping tests for windows since CSI does not support it yet") - } -} - -func (g *gcePDExternalCSIDriver) GetDynamicProvisionStorageClass(config *testsuites.PerTestConfig, fsType string) *storagev1.StorageClass { - ns := config.Framework.Namespace.Name - provisioner := g.driverInfo.Name - suffix := fmt.Sprintf("%s-sc", g.driverInfo.Name) - - parameters := map[string]string{"type": "pd-standard"} - if fsType != "" { - parameters["csi.storage.k8s.io/fstype"] = fsType - } - - return testsuites.GetStorageClass(provisioner, parameters, nil, ns, suffix) -} - -func (g *gcePDExternalCSIDriver) GetClaimSize() string { - return "5Gi" -} - -func (g *gcePDExternalCSIDriver) PrepareTest(f *framework.Framework) (*testsuites.PerTestConfig, func()) { - framework.SkipIfMultizone(f.ClientSet) - - return &testsuites.PerTestConfig{ - Driver: g, - Prefix: "gcepdext", - Framework: f, - }, func() {} -}