From aeef7fdca21fc44098c0aa6e0393b75200f5148b Mon Sep 17 00:00:00 2001 From: jianglingxia Date: Wed, 18 Jul 2018 17:27:24 +0800 Subject: [PATCH] Add UT to RBD volume test of TestGetAccessModes and TestRequiresRemount --- pkg/volume/rbd/rbd_test.go | 33 +++++++++++++++++++++++++++++++++ 1 file changed, 33 insertions(+) diff --git a/pkg/volume/rbd/rbd_test.go b/pkg/volume/rbd/rbd_test.go index 3a0ddf4720e..46f56b9345e 100644 --- a/pkg/volume/rbd/rbd_test.go +++ b/pkg/volume/rbd/rbd_test.go @@ -649,3 +649,36 @@ func TestConstructVolumeSpec(t *testing.T) { } } } + +func TestGetAccessModes(t *testing.T) { + tmpDir, err := utiltesting.MkTmpdir("rbd_test") + if err != nil { + t.Fatalf("error creating temp dir: %v", err) + } + defer os.RemoveAll(tmpDir) + + plugMgr := volume.VolumePluginMgr{} + plugMgr.InitPlugins(ProbeVolumePlugins(), nil /* prober */, volumetest.NewFakeVolumeHost(tmpDir, nil, nil)) + + plug, err := plugMgr.FindPersistentPluginByName("kubernetes.io/rbd") + if err != nil { + t.Errorf("Can't find the plugin by name") + } + modes := plug.GetAccessModes() + for _, v := range modes { + if !volumetest.ContainsAccessMode(modes, v) { + t.Errorf("Expected AccessModeTypes: %s", v) + } + } +} + +func TestRequiresRemount(t *testing.T) { + tmpDir, _ := utiltesting.MkTmpdir("rbd_test") + plugMgr := volume.VolumePluginMgr{} + plugMgr.InitPlugins(ProbeVolumePlugins(), nil /* prober */, volumetest.NewFakeVolumeHost(tmpDir, nil, nil)) + plug, _ := plugMgr.FindPluginByName("kubernetes.io/rbd") + has := plug.RequiresRemount() + if has { + t.Errorf("Exepcted RequiresRemount to be false, got %t", has) + } +}