From af09159419d5d9fbdc2543e31d38817a659daa27 Mon Sep 17 00:00:00 2001 From: xiangpengzhao Date: Fri, 16 Jun 2017 17:21:21 +0800 Subject: [PATCH] Add version info to kube-scheduler, kube-proxy and kubelet logs. --- cmd/kube-proxy/app/BUILD | 1 + cmd/kube-proxy/app/server.go | 3 +++ cmd/kubelet/app/server.go | 6 ++++-- plugin/cmd/kube-scheduler/app/BUILD | 1 + plugin/cmd/kube-scheduler/app/server.go | 4 ++++ 5 files changed, 13 insertions(+), 2 deletions(-) diff --git a/cmd/kube-proxy/app/BUILD b/cmd/kube-proxy/app/BUILD index 33a20675600..d8b9a49c1b5 100644 --- a/cmd/kube-proxy/app/BUILD +++ b/cmd/kube-proxy/app/BUILD @@ -44,6 +44,7 @@ go_library( "//pkg/util/pointer:go_default_library", "//pkg/util/resourcecontainer:go_default_library", "//pkg/util/sysctl:go_default_library", + "//pkg/version:go_default_library", "//pkg/version/verflag:go_default_library", "//vendor/github.com/golang/glog:go_default_library", "//vendor/github.com/prometheus/client_golang/prometheus:go_default_library", diff --git a/cmd/kube-proxy/app/server.go b/cmd/kube-proxy/app/server.go index 2b66fbea958..783fce01778 100644 --- a/cmd/kube-proxy/app/server.go +++ b/cmd/kube-proxy/app/server.go @@ -65,6 +65,7 @@ import ( "k8s.io/kubernetes/pkg/util/oom" utilpointer "k8s.io/kubernetes/pkg/util/pointer" "k8s.io/kubernetes/pkg/util/resourcecontainer" + "k8s.io/kubernetes/pkg/version" "k8s.io/kubernetes/pkg/version/verflag" "k8s.io/utils/exec" @@ -421,6 +422,8 @@ func createClients(config componentconfig.ClientConnectionConfiguration, masterO // Run runs the specified ProxyServer. This should never exit (unless CleanupAndExit is set). func (s *ProxyServer) Run() error { + // To help debugging, immediately log version + glog.Infof("Version: %+v", version.Get()) // remove iptables rules and exit if s.CleanupAndExit { encounteredError := userspace.CleanupLeftovers(s.IptInterface) diff --git a/cmd/kubelet/app/server.go b/cmd/kubelet/app/server.go index 406dba293f6..a8812e3d873 100644 --- a/cmd/kubelet/app/server.go +++ b/cmd/kubelet/app/server.go @@ -176,6 +176,8 @@ func UnsecuredDependencies(s *options.KubeletServer) (*kubelet.Dependencies, err // Otherwise, the caller is assumed to have set up the Dependencies object and a default one will // not be generated. func Run(s *options.KubeletServer, kubeDeps *kubelet.Dependencies) error { + // To help debugging, immediately log version + glog.Infof("Version: %+v", version.Get()) if err := run(s, kubeDeps); err != nil { return fmt.Errorf("failed to run Kubelet: %v", err) } @@ -712,10 +714,10 @@ func RunKubelet(kubeFlags *options.KubeletFlags, kubeCfg *kubeletconfiginternal. if _, err := k.RunOnce(podCfg.Updates()); err != nil { return fmt.Errorf("runonce failed: %v", err) } - glog.Infof("Started kubelet %s as runonce", version.Get().String()) + glog.Infof("Started kubelet as runonce") } else { startKubelet(k, podCfg, kubeCfg, kubeDeps) - glog.Infof("Started kubelet %s", version.Get().String()) + glog.Infof("Started kubelet") } return nil } diff --git a/plugin/cmd/kube-scheduler/app/BUILD b/plugin/cmd/kube-scheduler/app/BUILD index 39c97b1e6dc..f154f83e354 100644 --- a/plugin/cmd/kube-scheduler/app/BUILD +++ b/plugin/cmd/kube-scheduler/app/BUILD @@ -17,6 +17,7 @@ go_library( "//pkg/controller:go_default_library", "//pkg/features:go_default_library", "//pkg/util/configz:go_default_library", + "//pkg/version:go_default_library", "//plugin/cmd/kube-scheduler/app/options:go_default_library", "//plugin/pkg/scheduler:go_default_library", "//plugin/pkg/scheduler/algorithmprovider:go_default_library", diff --git a/plugin/cmd/kube-scheduler/app/server.go b/plugin/cmd/kube-scheduler/app/server.go index 05bbbec38fd..f489bf9a22e 100644 --- a/plugin/cmd/kube-scheduler/app/server.go +++ b/plugin/cmd/kube-scheduler/app/server.go @@ -34,6 +34,7 @@ import ( "k8s.io/client-go/tools/leaderelection/resourcelock" "k8s.io/kubernetes/pkg/controller" "k8s.io/kubernetes/pkg/util/configz" + "k8s.io/kubernetes/pkg/version" "k8s.io/kubernetes/plugin/cmd/kube-scheduler/app/options" _ "k8s.io/kubernetes/plugin/pkg/scheduler/algorithmprovider" "k8s.io/kubernetes/plugin/pkg/scheduler/factory" @@ -66,6 +67,9 @@ through the API as necessary.`, // Run runs the specified SchedulerServer. This should never exit. func Run(s *options.SchedulerServer) error { + // To help debugging, immediately log version + glog.Infof("Version: %+v", version.Get()) + kubecli, err := createClient(s) if err != nil { return fmt.Errorf("unable to create kube client: %v", err)