From 66f4242102b206b60de5cc41f9c3921e31d4bebe Mon Sep 17 00:00:00 2001 From: Maciej Szulik Date: Wed, 10 Oct 2018 21:05:02 +0200 Subject: [PATCH 1/2] Fix error argument --- .../cli-runtime/pkg/genericclioptions/resource/builder.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/staging/src/k8s.io/cli-runtime/pkg/genericclioptions/resource/builder.go b/staging/src/k8s.io/cli-runtime/pkg/genericclioptions/resource/builder.go index 22680c517c2..6a0d954f80b 100644 --- a/staging/src/k8s.io/cli-runtime/pkg/genericclioptions/resource/builder.go +++ b/staging/src/k8s.io/cli-runtime/pkg/genericclioptions/resource/builder.go @@ -1056,7 +1056,7 @@ func (b *Builder) visitByPaths() *Result { if b.labelSelector != nil { selector, err := labels.Parse(*b.labelSelector) if err != nil { - return result.withError(fmt.Errorf("the provided selector %q is not valid: %v", b.labelSelector, err)) + return result.withError(fmt.Errorf("the provided selector %q is not valid: %v", *b.labelSelector, err)) } visitors = NewFilteredVisitor(visitors, FilterByLabelSelector(selector)) } From e37c63ea71d9c86f9675fd93ec6b4e9dff70f2bf Mon Sep 17 00:00:00 2001 From: Maciej Szulik Date: Wed, 10 Oct 2018 21:07:38 +0200 Subject: [PATCH 2/2] Add cli-runtime to make tests --- hack/make-rules/test.sh | 3 +++ 1 file changed, 3 insertions(+) diff --git a/hack/make-rules/test.sh b/hack/make-rules/test.sh index 1b53d8dd94d..3a64cdb404c 100755 --- a/hack/make-rules/test.sh +++ b/hack/make-rules/test.sh @@ -95,6 +95,9 @@ kube::test::find_dirs() { find ./staging/src/k8s.io/sample-apiserver -name '*_test.go' \ -name '*_test.go' -print0 | xargs -0n1 dirname | sed 's|^\./staging/src/|./vendor/|' | LC_ALL=C sort -u + + find ./staging/src/k8s.io/cli-runtime -name '*_test.go' \ + -name '*_test.go' -print0 | xargs -0n1 dirname | sed 's|^\./staging/src/|./vendor/|' | LC_ALL=C sort -u ) }