From af5084ea75ed5273a33b9512dd8b970824109333 Mon Sep 17 00:00:00 2001
From: jiatongw <wjiatong@vmware.com>
Date: Mon, 6 Aug 2018 15:19:10 -0700
Subject: [PATCH] Add TestZone()

---
 .../providers/vsphere/vsphere_test.go          | 18 +++++++++++-------
 1 file changed, 11 insertions(+), 7 deletions(-)

diff --git a/pkg/cloudprovider/providers/vsphere/vsphere_test.go b/pkg/cloudprovider/providers/vsphere/vsphere_test.go
index 4220a327485..1b0becca6e3 100644
--- a/pkg/cloudprovider/providers/vsphere/vsphere_test.go
+++ b/pkg/cloudprovider/providers/vsphere/vsphere_test.go
@@ -315,17 +315,21 @@ func TestVSphereLoginWithCaCert(t *testing.T) {
 }
 
 func TestZones(t *testing.T) {
-	cfg := VSphereConfig{}
-	cfg.Global.Datacenter = "myDatacenter"
-
 	// Create vSphere configuration object
+	cfg, ok := configFromEnv()
 	vs := VSphere{
 		cfg: &cfg,
 	}
-
-	_, ok := vs.Zones()
-	if ok {
-		t.Fatalf("Zones() returned true")
+	if !ok {
+		t.Skipf("No config found in environment")
+	}
+	_, err := vs.GetZone(context.TODO())
+	if err != nil {
+		t.Fatalf("GetZone() failed: %s", err)
+	}
+	_, ok = vs.Zones()
+	if !ok {
+		t.Fatalf("Zones() returned false")
 	}
 }