From 2d942dab68b64e684dd2b75232cf9daabc6e0a95 Mon Sep 17 00:00:00 2001 From: Pengfei Ni Date: Fri, 23 Feb 2018 13:14:26 +0800 Subject: [PATCH] Disable mount propagation for windows containers --- pkg/kubelet/kubelet_pods.go | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/pkg/kubelet/kubelet_pods.go b/pkg/kubelet/kubelet_pods.go index 6d45170ed13..bc8dccdfcde 100644 --- a/pkg/kubelet/kubelet_pods.go +++ b/pkg/kubelet/kubelet_pods.go @@ -272,6 +272,12 @@ func makeMounts(pod *v1.Pod, podDir string, container *v1.Container, hostName, h // translateMountPropagation transforms v1.MountPropagationMode to // runtimeapi.MountPropagation. func translateMountPropagation(mountMode *v1.MountPropagationMode) (runtimeapi.MountPropagation, error) { + if runtime.GOOS == "windows" { + // Windows containers doesn't support mount propagation, use private for it. + // Refer https://docs.docker.com/storage/bind-mounts/#configure-bind-propagation. + return runtimeapi.MountPropagation_PROPAGATION_PRIVATE, nil + } + if !utilfeature.DefaultFeatureGate.Enabled(features.MountPropagation) { // mount propagation is disabled, use private as in the old versions return runtimeapi.MountPropagation_PROPAGATION_PRIVATE, nil