mirror of
https://github.com/k3s-io/kubernetes.git
synced 2025-07-24 12:15:52 +00:00
Merge pull request #82996 from tnqn/endpointslice-deletion
Fix EndpointSliceController service deletion processing
This commit is contained in:
commit
b00f009316
@ -251,6 +251,8 @@ func (c *Controller) syncService(key string) error {
|
||||
if err != nil {
|
||||
if apierrors.IsNotFound(err) {
|
||||
c.triggerTimeTracker.DeleteService(namespace, name)
|
||||
// The service has been deleted, return nil so that it won't be retried.
|
||||
return nil
|
||||
}
|
||||
return err
|
||||
}
|
||||
|
@ -140,9 +140,8 @@ func TestSyncServiceMissing(t *testing.T) {
|
||||
|
||||
err := esController.syncService(fmt.Sprintf("%s/%s", namespace, missingServiceName))
|
||||
|
||||
// Since the service doesn't exist, we should get a not found error
|
||||
assert.NotNil(t, err, "Expected no error syncing service")
|
||||
assert.Equal(t, err.Error(), "service \"notthere\" not found")
|
||||
// nil should be returned when the service doesn't exist
|
||||
assert.Nil(t, err, "Expected no error syncing service")
|
||||
|
||||
// That should mean no client actions were performed
|
||||
assert.Len(t, client.Actions(), 0)
|
||||
|
Loading…
Reference in New Issue
Block a user