github/kubernetes
1
0
Fork 0
mirror of https://github.com/k3s-io/kubernetes.git synced 2025-07-28 14:07:14 +00:00
Code Issues Projects Releases Wiki Activity

fix bugs that break processing when printing errors occur in kubectl

Browse Source
This commit is contained in:
WanLinghao 2018-05-24 09:48:24 +08:00
parent b5cd7d81bd
commit b020a4ba8c
7 changed files with 21 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
pkg/kubectl/cmd/rollout/rollout_pause.go
View File

@ -153,7 +153,9 @@ func (o PauseConfig) RunPause() error {
allErrs = append(allErrs, err) allErrs = append(allErrs, err)
continue continue
} }
printer.PrintObj(cmdutil.AsDefaultVersionedOrOriginal(info.Object, info.Mapping), o.Out) if err = printer.PrintObj(cmdutil.AsDefaultVersionedOrOriginal(info.Object, info.Mapping), o.Out); err != nil {
allErrs = append(allErrs, err)
}
continue continue
} }
@ -169,7 +171,9 @@ func (o PauseConfig) RunPause() error {
allErrs = append(allErrs, err) allErrs = append(allErrs, err)
continue continue
} }
printer.PrintObj(cmdutil.AsDefaultVersionedOrOriginal(info.Object, info.Mapping), o.Out) if err = printer.PrintObj(cmdutil.AsDefaultVersionedOrOriginal(info.Object, info.Mapping), o.Out); err != nil {
allErrs = append(allErrs, err)
}
} }
return utilerrors.NewAggregate(allErrs) return utilerrors.NewAggregate(allErrs)

8
pkg/kubectl/cmd/rollout/rollout_resume.go
View File

@ -158,7 +158,9 @@ func (o ResumeConfig) RunResume() error {
allErrs = append(allErrs, err) allErrs = append(allErrs, err)
continue continue
} }
printer.PrintObj(cmdutil.AsDefaultVersionedOrOriginal(info.Object, info.Mapping), o.Out) if err = printer.PrintObj(cmdutil.AsDefaultVersionedOrOriginal(info.Object, info.Mapping), o.Out); err != nil {
allErrs = append(allErrs, err)
}
} }
obj, err := resource.NewHelper(info.Client, info.Mapping).Patch(info.Namespace, info.Name, types.StrategicMergePatchType, patch.Patch) obj, err := resource.NewHelper(info.Client, info.Mapping).Patch(info.Namespace, info.Name, types.StrategicMergePatchType, patch.Patch)
@ -173,7 +175,9 @@ func (o ResumeConfig) RunResume() error {
allErrs = append(allErrs, err) allErrs = append(allErrs, err)
continue continue
} }
printer.PrintObj(cmdutil.AsDefaultVersionedOrOriginal(info.Object, info.Mapping), o.Out) if err = printer.PrintObj(cmdutil.AsDefaultVersionedOrOriginal(info.Object, info.Mapping), o.Out); err != nil {
allErrs = append(allErrs, err)
}
} }
return utilerrors.NewAggregate(allErrs) return utilerrors.NewAggregate(allErrs)

4
pkg/kubectl/cmd/set/set_env.go
View File

@ -415,7 +415,7 @@ func (o *EnvOptions) RunEnv() error {
if o.Local || o.dryRun { if o.Local || o.dryRun {
if err := o.PrintObj(info.Object, o.Out); err != nil { if err := o.PrintObj(info.Object, o.Out); err != nil {
return err allErrs = append(allErrs, err)
} }
continue continue
} }
@ -433,7 +433,7 @@ func (o *EnvOptions) RunEnv() error {
} }
if err := o.PrintObj(actual, o.Out); err != nil { if err := o.PrintObj(actual, o.Out); err != nil {
return err allErrs = append(allErrs, err)
} }
} }
return utilerrors.NewAggregate(allErrs) return utilerrors.NewAggregate(allErrs)

4
pkg/kubectl/cmd/set/set_image.go
View File

@ -276,7 +276,7 @@ func (o *SetImageOptions) Run() error {
if o.Local || o.DryRun { if o.Local || o.DryRun {
if err := o.PrintObj(info.Object, o.Out); err != nil { if err := o.PrintObj(info.Object, o.Out); err != nil {
return err allErrs = append(allErrs, err)
} }
continue continue
} }
@ -289,7 +289,7 @@ func (o *SetImageOptions) Run() error {
} }
if err := o.PrintObj(actual, o.Out); err != nil { if err := o.PrintObj(actual, o.Out); err != nil {
return err allErrs = append(allErrs, err)
} }
} }
return utilerrors.NewAggregate(allErrs) return utilerrors.NewAggregate(allErrs)

4
pkg/kubectl/cmd/set/set_resources.go
View File

@ -277,7 +277,7 @@ func (o *SetResourcesOptions) Run() error {
if o.Local || o.DryRun { if o.Local || o.DryRun {
if err := o.PrintObj(info.Object, o.Out); err != nil { if err := o.PrintObj(info.Object, o.Out); err != nil {
return err allErrs = append(allErrs, err)
} }
continue continue
} }
@ -289,7 +289,7 @@ func (o *SetResourcesOptions) Run() error {
} }
if err := o.PrintObj(actual, o.Out); err != nil { if err := o.PrintObj(actual, o.Out); err != nil {
return err allErrs = append(allErrs, err)
} }
} }
return utilerrors.NewAggregate(allErrs) return utilerrors.NewAggregate(allErrs)

4
pkg/kubectl/cmd/set/set_serviceaccount.go
View File

@ -198,7 +198,7 @@ func (o *SetServiceAccountOptions) Run() error {
} }
if o.local || o.dryRun { if o.local || o.dryRun {
if err := o.PrintObj(info.Object, o.Out); err != nil { if err := o.PrintObj(info.Object, o.Out); err != nil {
return err patchErrs = append(patchErrs, err)
} }
continue continue
} }
@ -209,7 +209,7 @@ func (o *SetServiceAccountOptions) Run() error {
} }
if err := o.PrintObj(actual, o.Out); err != nil { if err := o.PrintObj(actual, o.Out); err != nil {
return err patchErrs = append(patchErrs, err)
} }
} }
return utilerrors.NewAggregate(patchErrs) return utilerrors.NewAggregate(patchErrs)

2
pkg/kubectl/cmd/set/set_subject.go
View File

@ -251,7 +251,7 @@ func (o *SubjectOptions) Run(fn updateSubjects) error {
if o.Local || o.DryRun { if o.Local || o.DryRun {
if err := o.PrintObj(info.Object, o.Out); err != nil { if err := o.PrintObj(info.Object, o.Out); err != nil {
return err allErrs = append(allErrs, err)
} }
continue continue
} }