mirror of
https://github.com/k3s-io/kubernetes.git
synced 2025-07-23 11:50:44 +00:00
Merge pull request #42294 from mlmhl/deploy-controller-cachesync
Automatic merge from submit-queue fix rsListerSynced and podListerSynced for DeploymentController **What this PR does / why we need it**: There is a mistake when initializing `DeploymentController`'s `rsListerSynced` and `podListerSynced` in `NewDeploymentController`, they are all initialized to `Deployment`'s `Informer`, so the `DeploymentController` maybe running before the `ReplicaSet` cache and `Pod` cache has been synced. **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes # **Special notes for your reviewer**: Indeed according unit test is neccessary, but this bug fix is simple, and if the tests is neccessary I will submit another PR later. **Release note**: ```release-note ```
This commit is contained in:
commit
b0d2f68ce3
@ -138,8 +138,8 @@ func NewDeploymentController(dInformer extensionsinformers.DeploymentInformer, r
|
||||
dc.rsLister = rsInformer.Lister()
|
||||
dc.podLister = podInformer.Lister()
|
||||
dc.dListerSynced = dInformer.Informer().HasSynced
|
||||
dc.rsListerSynced = dInformer.Informer().HasSynced
|
||||
dc.podListerSynced = dInformer.Informer().HasSynced
|
||||
dc.rsListerSynced = rsInformer.Informer().HasSynced
|
||||
dc.podListerSynced = podInformer.Informer().HasSynced
|
||||
return dc
|
||||
}
|
||||
|
||||
|
Loading…
Reference in New Issue
Block a user