github/kubernetes
1
0
Fork 0
mirror of https://github.com/k3s-io/kubernetes.git synced 2025-08-10 12:32:03 +00:00
Code Issues Projects Releases Wiki Activity

e2e/network/conntrack: rename invalid conntrack state test

Browse Source 
Signed-off-by: Daman Arora <aroradaman@gmail.com>
This commit is contained in:
Daman Arora 2024-01-11 03:11:42 +05:30
parent 4ffa12b9d9
commit b0e929264f
1 changed files with 15 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

29
test/e2e/network/conntrack.go
View File

@ -433,13 +433,15 @@ var _ = common.SIGDescribe("Conntrack", func() {
}) })
// Regression test for #74839, where: // Regression test for #74839
// Packets considered INVALID by conntrack are now dropped. In particular, this fixes // Packets considered INVALID by conntrack are not NATed, this can result
// a problem where spurious retransmits in a long-running TCP connection to a service // in a problem where spurious retransmits in a long-running TCP connection
// IP could result in the connection being closed with the error "Connection reset by // to a service IP ends up with "Connection reset by peer" error.
// peer" // Proxy implementations (which leverage conntrack) can either drop packets
// marked INVALID by conntrack or enforce `nf_conntrack_tcp_be_liberal` to
// overcome this.
// xref: https://kubernetes.io/blog/2019/03/29/kube-proxy-subtleties-debugging-an-intermittent-connection-reset/ // xref: https://kubernetes.io/blog/2019/03/29/kube-proxy-subtleties-debugging-an-intermittent-connection-reset/
ginkgo.It("should drop INVALID conntrack entries [Privileged]", func(ctx context.Context) { ginkgo.It("proxy implementation should not be vulnerable to the invalid conntrack state bug [Privileged]", func(ctx context.Context) {
serverLabel := map[string]string{ serverLabel := map[string]string{
"app": "boom-server", "app": "boom-server",
} }
@ -535,22 +537,21 @@ var _ = common.SIGDescribe("Conntrack", func() {
e2epod.NewPodClient(fr).CreateSync(ctx, pod) e2epod.NewPodClient(fr).CreateSync(ctx, pod)
ginkgo.By("Client pod created") ginkgo.By("Client pod created")
// The client will open connections against the server // The client will open connections against the server.
// The server will inject invalid packets // The server will inject packets with out-of-window sequence numbers and
// if conntrack does not drop the invalid packets it will go through without NAT // if these packets go without NAT client will receive an unexpected TCP
// so the client will receive an unexpected TCP connection and RST the connection // packet and RST the connection, the server will log ERROR if that happens.
// the server will log ERROR if that happens ginkgo.By("checking client pod does not RST the TCP connection because it receives an out-of-window packet")
ginkgo.By("checking client pod does not RST the TCP connection because it receives an INVALID packet")
if err := wait.PollUntilContextTimeout(ctx, 5*time.Second, time.Minute, true, logContainsFn("ERROR", "boom-server")); err == nil { if err := wait.PollUntilContextTimeout(ctx, 5*time.Second, time.Minute, true, logContainsFn("ERROR", "boom-server")); err == nil {
logs, err := e2epod.GetPodLogs(ctx, cs, ns, "boom-server", "boom-server") logs, err := e2epod.GetPodLogs(ctx, cs, ns, "boom-server", "boom-server")
framework.ExpectNoError(err) framework.ExpectNoError(err)
framework.Logf("boom-server pod logs: %s", logs) framework.Logf("boom-server pod logs: %s", logs)
framework.Failf("boom-server pod received a RST from the client") framework.Failf("boom-server pod received a RST from the client, enabling nf_conntrack_tcp_be_liberal or dropping packets marked invalid by conntrack might help here.")
} }
logs, err := e2epod.GetPodLogs(ctx, cs, ns, "boom-server", "boom-server") logs, err := e2epod.GetPodLogs(ctx, cs, ns, "boom-server", "boom-server")
framework.ExpectNoError(err) framework.ExpectNoError(err)
if !strings.Contains(string(logs), "connection established") { if !strings.Contains(logs, "connection established") {
framework.Logf("boom-server pod logs: %s", logs) framework.Logf("boom-server pod logs: %s", logs)
framework.Failf("boom-server pod did not send any bad packet to the client") framework.Failf("boom-server pod did not send any bad packet to the client")
} }