Merge pull request #80606 from andrewsykim/cloud-config-api

document API guarentees and deprecation policies for cloud config files
This commit is contained in:
Kubernetes Prow Robot 2019-07-29 19:54:50 -07:00 committed by GitHub
commit b120bc7e33
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
5 changed files with 25 additions and 0 deletions

View File

@ -146,6 +146,11 @@ type OpenStack struct {
} }
// Config is used to read and store information from the cloud configuration file // Config is used to read and store information from the cloud configuration file
// NOTE: Cloud config files should follow the same Kubernetes deprecation policy as
// flags or CLIs. Config fields should not change behavior in incompatible ways and
// should be deprecated for at least 2 release prior to removing.
// See https://kubernetes.io/docs/reference/using-api/deprecation-policy/#deprecating-a-flag-or-cli
// for more details.
type Config struct { type Config struct {
Global struct { Global struct {
AuthURL string `gcfg:"auth-url"` AuthURL string `gcfg:"auth-url"`

View File

@ -535,6 +535,11 @@ type Cloud struct {
var _ Volumes = &Cloud{} var _ Volumes = &Cloud{}
// CloudConfig wraps the settings for the AWS cloud provider. // CloudConfig wraps the settings for the AWS cloud provider.
// NOTE: Cloud config files should follow the same Kubernetes deprecation policy as
// flags or CLIs. Config fields should not change behavior in incompatible ways and
// should be deprecated for at least 2 release prior to removing.
// See https://kubernetes.io/docs/reference/using-api/deprecation-policy/#deprecating-a-flag-or-cli
// for more details.
type CloudConfig struct { type CloudConfig struct {
Global struct { Global struct {
// TODO: Is there any use for this? We can get it from the instance metadata service // TODO: Is there any use for this? We can get it from the instance metadata service

View File

@ -79,6 +79,11 @@ var (
// Config holds the configuration parsed from the --cloud-config flag // Config holds the configuration parsed from the --cloud-config flag
// All fields are required unless otherwise specified // All fields are required unless otherwise specified
// NOTE: Cloud config files should follow the same Kubernetes deprecation policy as
// flags or CLIs. Config fields should not change behavior in incompatible ways and
// should be deprecated for at least 2 release prior to removing.
// See https://kubernetes.io/docs/reference/using-api/deprecation-policy/#deprecating-a-flag-or-cli
// for more details.
type Config struct { type Config struct {
auth.AzureAuthConfig auth.AzureAuthConfig

View File

@ -186,6 +186,11 @@ type ConfigGlobal struct {
} }
// ConfigFile is the struct used to parse the /etc/gce.conf configuration file. // ConfigFile is the struct used to parse the /etc/gce.conf configuration file.
// NOTE: Cloud config files should follow the same Kubernetes deprecation policy as
// flags or CLIs. Config fields should not change behavior in incompatible ways and
// should be deprecated for at least 2 release prior to removing.
// See https://kubernetes.io/docs/reference/using-api/deprecation-policy/#deprecating-a-flag-or-cli
// for more details.
type ConfigFile struct { type ConfigFile struct {
Global ConfigGlobal `gcfg:"global"` Global ConfigGlobal `gcfg:"global"`
} }

View File

@ -123,6 +123,11 @@ type VirtualCenterConfig struct {
// Structure that represents the content of vsphere.conf file. // Structure that represents the content of vsphere.conf file.
// Users specify the configuration of one or more Virtual Centers in vsphere.conf where // Users specify the configuration of one or more Virtual Centers in vsphere.conf where
// the Kubernetes master and worker nodes are running. // the Kubernetes master and worker nodes are running.
// NOTE: Cloud config files should follow the same Kubernetes deprecation policy as
// flags or CLIs. Config fields should not change behavior in incompatible ways and
// should be deprecated for at least 2 release prior to removing.
// See https://kubernetes.io/docs/reference/using-api/deprecation-policy/#deprecating-a-flag-or-cli
// for more details.
type VSphereConfig struct { type VSphereConfig struct {
Global struct { Global struct {
// vCenter username. // vCenter username.