From b1d027742b847a17e230af035a9b21da99121d66 Mon Sep 17 00:00:00 2001 From: Joakim Roubert Date: Sun, 19 Jan 2020 20:08:44 +0100 Subject: [PATCH] Update for loop in server image image creation Signed-off-by: Joakim Roubert --- build/lib/release.sh | 13 +++---------- 1 file changed, 3 insertions(+), 10 deletions(-) diff --git a/build/lib/release.sh b/build/lib/release.sh index bb4dbf41eb5..069c35613ce 100644 --- a/build/lib/release.sh +++ b/build/lib/release.sh @@ -372,17 +372,10 @@ function kube::release::create_docker_images_for_server() { docker_build_opts='--pull' fi - for wrappable in "${binaries[@]}"; do + for wrappable in $binaries; do - local oldifs=$IFS - IFS="," - # Word splitting is most intentional here - # shellcheck disable=SC2086 - set $wrappable - IFS=$oldifs - - local binary_name="$1" - local base_image="$2" + local binary_name=${wrappable%%,*} + local base_image=${wrappable##*,} local binary_file_path="${binary_dir}/${binary_name}" local docker_build_path="${binary_file_path}.dockerbuild" local docker_file_path="${docker_build_path}/Dockerfile"