From 1e0bbe61ae4d4e186bc8d0991210d1613dc71996 Mon Sep 17 00:00:00 2001 From: Obeyda Djeffal Date: Wed, 4 Nov 2020 09:51:01 +0100 Subject: [PATCH 1/2] replace string casting with fmt.sprintf in test in: staging/src/k8s.io/kubectl/pkg/cmd/create/create_rolebinding_test.go test: TestCreateRoleBinding On go version 1.15.3, casting int to string using `string(int)` causes the test to fail with this error: >> k8s.io/kubernetes/vendor/k8s.io/kubectl/pkg/cmd/create vendor/k8s.io/kubectl/pkg/cmd/create/create_rolebinding_test.go:75:9: conversion from int to string yields a string of one rune, not a string of digits (did you mean fmt.Sprint(x)?) FAIL k8s.io/kubernetes/vendor/k8s.io/kubectl/pkg/cmd/create [build failed] FAIL make: *** [Makefile:185: test] Error 1 --- .../k8s.io/kubectl/pkg/cmd/create/create_rolebinding_test.go | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/staging/src/k8s.io/kubectl/pkg/cmd/create/create_rolebinding_test.go b/staging/src/k8s.io/kubectl/pkg/cmd/create/create_rolebinding_test.go index d7cd79f6136..577ef326eb3 100644 --- a/staging/src/k8s.io/kubectl/pkg/cmd/create/create_rolebinding_test.go +++ b/staging/src/k8s.io/kubectl/pkg/cmd/create/create_rolebinding_test.go @@ -17,6 +17,7 @@ limitations under the License. package create import ( + "fmt" "testing" rbac "k8s.io/api/rbac/v1" @@ -72,7 +73,7 @@ func TestCreateRoleBinding(t *testing.T) { } for i, tc := range tests { - t.Run(string(i), func(t *testing.T) { + t.Run(fmt.Sprintf("%d", i), func(t *testing.T) { roleBinding, err := tc.options.createRoleBinding() if err != nil { t.Errorf("unexpected error:\n%#v\n", err) From 20da5a9d8e7d5a1290c028b9489a7ab31a0c45bb Mon Sep 17 00:00:00 2001 From: Obeyda Djeffal Date: Wed, 4 Nov 2020 11:50:03 +0100 Subject: [PATCH 2/2] Update staging/src/k8s.io/kubectl/pkg/cmd/create/create_rolebinding_test.go Co-authored-by: Jian Zeng --- .../k8s.io/kubectl/pkg/cmd/create/create_rolebinding_test.go | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/staging/src/k8s.io/kubectl/pkg/cmd/create/create_rolebinding_test.go b/staging/src/k8s.io/kubectl/pkg/cmd/create/create_rolebinding_test.go index 577ef326eb3..6d063ca17e9 100644 --- a/staging/src/k8s.io/kubectl/pkg/cmd/create/create_rolebinding_test.go +++ b/staging/src/k8s.io/kubectl/pkg/cmd/create/create_rolebinding_test.go @@ -17,7 +17,7 @@ limitations under the License. package create import ( - "fmt" + "strconv" "testing" rbac "k8s.io/api/rbac/v1" @@ -73,7 +73,7 @@ func TestCreateRoleBinding(t *testing.T) { } for i, tc := range tests { - t.Run(fmt.Sprintf("%d", i), func(t *testing.T) { + t.Run(strconv.Itoa(i), func(t *testing.T) { roleBinding, err := tc.options.createRoleBinding() if err != nil { t.Errorf("unexpected error:\n%#v\n", err)