From 645b25ec67c0a68c39c58ee5ec707fff2d896f4d Mon Sep 17 00:00:00 2001 From: Artur Rodrigues Date: Sun, 7 Apr 2024 16:15:06 +0100 Subject: [PATCH 1/2] scheduler: fix typo in metric pod_scheduling_sli_duration_seconds help --- pkg/scheduler/metrics/metrics.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pkg/scheduler/metrics/metrics.go b/pkg/scheduler/metrics/metrics.go index a96c1d33511..14d46c82cbf 100644 --- a/pkg/scheduler/metrics/metrics.go +++ b/pkg/scheduler/metrics/metrics.go @@ -132,7 +132,7 @@ var ( &metrics.HistogramOpts{ Subsystem: SchedulerSubsystem, Name: "pod_scheduling_sli_duration_seconds", - Help: "E2e latency for a pod being scheduled, from the time the pod enters the scheduling queue an d might involve multiple scheduling attempts.", + Help: "E2e latency for a pod being scheduled, from the time the pod enters the scheduling queue and might involve multiple scheduling attempts.", // Start with 10ms with the last bucket being [~88m, Inf). Buckets: metrics.ExponentialBuckets(0.01, 2, 20), StabilityLevel: metrics.BETA, From 7e4088602018f7f2239beab43996a09244a2339b Mon Sep 17 00:00:00 2001 From: Artur Rodrigues Date: Mon, 8 Apr 2024 08:35:28 +0100 Subject: [PATCH 2/2] Fix spelling in tests --- test/instrumentation/documentation/documentation-list.yaml | 2 +- test/instrumentation/documentation/documentation.md | 2 +- test/instrumentation/testdata/stable-metrics-list.yaml | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/test/instrumentation/documentation/documentation-list.yaml b/test/instrumentation/documentation/documentation-list.yaml index d3988602583..48f0395aad5 100644 --- a/test/instrumentation/documentation/documentation-list.yaml +++ b/test/instrumentation/documentation/documentation-list.yaml @@ -2148,7 +2148,7 @@ - name: pod_scheduling_sli_duration_seconds subsystem: scheduler help: E2e latency for a pod being scheduled, from the time the pod enters the scheduling - queue an d might involve multiple scheduling attempts. + queue and might involve multiple scheduling attempts. type: Histogram stabilityLevel: BETA labels: diff --git a/test/instrumentation/documentation/documentation.md b/test/instrumentation/documentation/documentation.md index a000c7fa49a..00f534aaa2d 100644 --- a/test/instrumentation/documentation/documentation.md +++ b/test/instrumentation/documentation/documentation.md @@ -362,7 +362,7 @@ Beta metrics observe a looser API contract than its stable counterparts. No labe
  • deprecated_versionstability_level
  • scheduler_pod_scheduling_sli_duration_seconds
    -
    E2e latency for a pod being scheduled, from the time the pod enters the scheduling queue an d might involve multiple scheduling attempts.
    +
    E2e latency for a pod being scheduled, from the time the pod enters the scheduling queue and might involve multiple scheduling attempts.
    • BETA
    • Histogram
    • diff --git a/test/instrumentation/testdata/stable-metrics-list.yaml b/test/instrumentation/testdata/stable-metrics-list.yaml index 11738980ed6..644371ab370 100644 --- a/test/instrumentation/testdata/stable-metrics-list.yaml +++ b/test/instrumentation/testdata/stable-metrics-list.yaml @@ -107,7 +107,7 @@ - name: pod_scheduling_sli_duration_seconds subsystem: scheduler help: E2e latency for a pod being scheduled, from the time the pod enters the scheduling - queue an d might involve multiple scheduling attempts. + queue and might involve multiple scheduling attempts. type: Histogram stabilityLevel: BETA labels: