diff --git a/pkg/api/deep_copy_generated.go b/pkg/api/deep_copy_generated.go index a3b2b03f424..4df7d95fa6c 100644 --- a/pkg/api/deep_copy_generated.go +++ b/pkg/api/deep_copy_generated.go @@ -2091,13 +2091,13 @@ func deepCopy_api_VolumeSource(in VolumeSource, out *VolumeSource, c *conversion } else { out.Glusterfs = nil } - if in.PersistentVolumeClaimVolumeSource != nil { - out.PersistentVolumeClaimVolumeSource = new(PersistentVolumeClaimVolumeSource) - if err := deepCopy_api_PersistentVolumeClaimVolumeSource(*in.PersistentVolumeClaimVolumeSource, out.PersistentVolumeClaimVolumeSource, c); err != nil { + if in.PersistentVolumeClaim != nil { + out.PersistentVolumeClaim = new(PersistentVolumeClaimVolumeSource) + if err := deepCopy_api_PersistentVolumeClaimVolumeSource(*in.PersistentVolumeClaim, out.PersistentVolumeClaim, c); err != nil { return err } } else { - out.PersistentVolumeClaimVolumeSource = nil + out.PersistentVolumeClaim = nil } if in.RBD != nil { out.RBD = new(RBDVolumeSource) diff --git a/pkg/api/types.go b/pkg/api/types.go index 1541f1ed593..84cc2855502 100644 --- a/pkg/api/types.go +++ b/pkg/api/types.go @@ -204,7 +204,7 @@ type VolumeSource struct { // Glusterfs represents a Glusterfs mount on the host that shares a pod's lifetime Glusterfs *GlusterfsVolumeSource `json:"glusterfs,omitempty"` // PersistentVolumeClaimVolumeSource represents a reference to a PersistentVolumeClaim in the same namespace - PersistentVolumeClaimVolumeSource *PersistentVolumeClaimVolumeSource `json:"persistentVolumeClaim,omitempty"` + PersistentVolumeClaim *PersistentVolumeClaimVolumeSource `json:"persistentVolumeClaim,omitempty"` // RBD represents a Rados Block Device mount on the host that shares a pod's lifetime RBD *RBDVolumeSource `json:"rbd,omitempty"` } diff --git a/pkg/api/v1/conversion_generated.go b/pkg/api/v1/conversion_generated.go index e47b53c5a33..02370bc4ca7 100644 --- a/pkg/api/v1/conversion_generated.go +++ b/pkg/api/v1/conversion_generated.go @@ -2314,13 +2314,13 @@ func convert_api_VolumeSource_To_v1_VolumeSource(in *api.VolumeSource, out *Volu } else { out.Glusterfs = nil } - if in.PersistentVolumeClaimVolumeSource != nil { - out.PersistentVolumeClaimVolumeSource = new(PersistentVolumeClaimVolumeSource) - if err := convert_api_PersistentVolumeClaimVolumeSource_To_v1_PersistentVolumeClaimVolumeSource(in.PersistentVolumeClaimVolumeSource, out.PersistentVolumeClaimVolumeSource, s); err != nil { + if in.PersistentVolumeClaim != nil { + out.PersistentVolumeClaim = new(PersistentVolumeClaimVolumeSource) + if err := convert_api_PersistentVolumeClaimVolumeSource_To_v1_PersistentVolumeClaimVolumeSource(in.PersistentVolumeClaim, out.PersistentVolumeClaim, s); err != nil { return err } } else { - out.PersistentVolumeClaimVolumeSource = nil + out.PersistentVolumeClaim = nil } if in.RBD != nil { out.RBD = new(RBDVolumeSource) @@ -4622,13 +4622,13 @@ func convert_v1_VolumeSource_To_api_VolumeSource(in *VolumeSource, out *api.Volu } else { out.Glusterfs = nil } - if in.PersistentVolumeClaimVolumeSource != nil { - out.PersistentVolumeClaimVolumeSource = new(api.PersistentVolumeClaimVolumeSource) - if err := convert_v1_PersistentVolumeClaimVolumeSource_To_api_PersistentVolumeClaimVolumeSource(in.PersistentVolumeClaimVolumeSource, out.PersistentVolumeClaimVolumeSource, s); err != nil { + if in.PersistentVolumeClaim != nil { + out.PersistentVolumeClaim = new(api.PersistentVolumeClaimVolumeSource) + if err := convert_v1_PersistentVolumeClaimVolumeSource_To_api_PersistentVolumeClaimVolumeSource(in.PersistentVolumeClaim, out.PersistentVolumeClaim, s); err != nil { return err } } else { - out.PersistentVolumeClaimVolumeSource = nil + out.PersistentVolumeClaim = nil } if in.RBD != nil { out.RBD = new(api.RBDVolumeSource) diff --git a/pkg/api/v1/deep_copy_generated.go b/pkg/api/v1/deep_copy_generated.go index 978d3652be3..0cb2fdf5091 100644 --- a/pkg/api/v1/deep_copy_generated.go +++ b/pkg/api/v1/deep_copy_generated.go @@ -2027,13 +2027,13 @@ func deepCopy_v1_VolumeSource(in VolumeSource, out *VolumeSource, c *conversion. } else { out.Glusterfs = nil } - if in.PersistentVolumeClaimVolumeSource != nil { - out.PersistentVolumeClaimVolumeSource = new(PersistentVolumeClaimVolumeSource) - if err := deepCopy_v1_PersistentVolumeClaimVolumeSource(*in.PersistentVolumeClaimVolumeSource, out.PersistentVolumeClaimVolumeSource, c); err != nil { + if in.PersistentVolumeClaim != nil { + out.PersistentVolumeClaim = new(PersistentVolumeClaimVolumeSource) + if err := deepCopy_v1_PersistentVolumeClaimVolumeSource(*in.PersistentVolumeClaim, out.PersistentVolumeClaim, c); err != nil { return err } } else { - out.PersistentVolumeClaimVolumeSource = nil + out.PersistentVolumeClaim = nil } if in.RBD != nil { out.RBD = new(RBDVolumeSource) diff --git a/pkg/api/v1/types.go b/pkg/api/v1/types.go index 8abc38b22e3..ce41ae764d8 100644 --- a/pkg/api/v1/types.go +++ b/pkg/api/v1/types.go @@ -221,7 +221,7 @@ type VolumeSource struct { // Glusterfs represents a Glusterfs mount on the host that shares a pod's lifetime Glusterfs *GlusterfsVolumeSource `json:"glusterfs,omitempty" description:"Glusterfs volume that will be mounted on the host machine "` // PersistentVolumeClaimVolumeSource represents a reference to a PersistentVolumeClaim in the same namespace - PersistentVolumeClaimVolumeSource *PersistentVolumeClaimVolumeSource `json:"persistentVolumeClaim,omitempty" description:"a reference to a PersistentVolumeClaim in the same namespace"` + PersistentVolumeClaim *PersistentVolumeClaimVolumeSource `json:"persistentVolumeClaim,omitempty" description:"a reference to a PersistentVolumeClaim in the same namespace"` // RBD represents a Rados Block Device mount on the host that shares a pod's lifetime RBD *RBDVolumeSource `json:"rbd,omitempty" description:"rados block volume that will be mounted on the host machine"` } diff --git a/pkg/api/v1beta3/conversion_generated.go b/pkg/api/v1beta3/conversion_generated.go index e373b9acfa6..3fdac31ac19 100644 --- a/pkg/api/v1beta3/conversion_generated.go +++ b/pkg/api/v1beta3/conversion_generated.go @@ -2068,13 +2068,13 @@ func convert_api_VolumeSource_To_v1beta3_VolumeSource(in *api.VolumeSource, out } else { out.Glusterfs = nil } - if in.PersistentVolumeClaimVolumeSource != nil { - out.PersistentVolumeClaimVolumeSource = new(PersistentVolumeClaimVolumeSource) - if err := convert_api_PersistentVolumeClaimVolumeSource_To_v1beta3_PersistentVolumeClaimVolumeSource(in.PersistentVolumeClaimVolumeSource, out.PersistentVolumeClaimVolumeSource, s); err != nil { + if in.PersistentVolumeClaim != nil { + out.PersistentVolumeClaim = new(PersistentVolumeClaimVolumeSource) + if err := convert_api_PersistentVolumeClaimVolumeSource_To_v1beta3_PersistentVolumeClaimVolumeSource(in.PersistentVolumeClaim, out.PersistentVolumeClaim, s); err != nil { return err } } else { - out.PersistentVolumeClaimVolumeSource = nil + out.PersistentVolumeClaim = nil } if in.RBD != nil { out.RBD = new(RBDVolumeSource) @@ -4130,13 +4130,13 @@ func convert_v1beta3_VolumeSource_To_api_VolumeSource(in *VolumeSource, out *api } else { out.Glusterfs = nil } - if in.PersistentVolumeClaimVolumeSource != nil { - out.PersistentVolumeClaimVolumeSource = new(api.PersistentVolumeClaimVolumeSource) - if err := convert_v1beta3_PersistentVolumeClaimVolumeSource_To_api_PersistentVolumeClaimVolumeSource(in.PersistentVolumeClaimVolumeSource, out.PersistentVolumeClaimVolumeSource, s); err != nil { + if in.PersistentVolumeClaim != nil { + out.PersistentVolumeClaim = new(api.PersistentVolumeClaimVolumeSource) + if err := convert_v1beta3_PersistentVolumeClaimVolumeSource_To_api_PersistentVolumeClaimVolumeSource(in.PersistentVolumeClaim, out.PersistentVolumeClaim, s); err != nil { return err } } else { - out.PersistentVolumeClaimVolumeSource = nil + out.PersistentVolumeClaim = nil } if in.RBD != nil { out.RBD = new(api.RBDVolumeSource) diff --git a/pkg/api/v1beta3/deep_copy_generated.go b/pkg/api/v1beta3/deep_copy_generated.go index 441f4ef5ec3..ebc9df77517 100644 --- a/pkg/api/v1beta3/deep_copy_generated.go +++ b/pkg/api/v1beta3/deep_copy_generated.go @@ -2027,13 +2027,13 @@ func deepCopy_v1beta3_VolumeSource(in VolumeSource, out *VolumeSource, c *conver } else { out.Glusterfs = nil } - if in.PersistentVolumeClaimVolumeSource != nil { - out.PersistentVolumeClaimVolumeSource = new(PersistentVolumeClaimVolumeSource) - if err := deepCopy_v1beta3_PersistentVolumeClaimVolumeSource(*in.PersistentVolumeClaimVolumeSource, out.PersistentVolumeClaimVolumeSource, c); err != nil { + if in.PersistentVolumeClaim != nil { + out.PersistentVolumeClaim = new(PersistentVolumeClaimVolumeSource) + if err := deepCopy_v1beta3_PersistentVolumeClaimVolumeSource(*in.PersistentVolumeClaim, out.PersistentVolumeClaim, c); err != nil { return err } } else { - out.PersistentVolumeClaimVolumeSource = nil + out.PersistentVolumeClaim = nil } if in.RBD != nil { out.RBD = new(RBDVolumeSource) diff --git a/pkg/api/v1beta3/types.go b/pkg/api/v1beta3/types.go index f3235aaa1a2..0b457416c68 100644 --- a/pkg/api/v1beta3/types.go +++ b/pkg/api/v1beta3/types.go @@ -221,7 +221,7 @@ type VolumeSource struct { // Glusterfs represents a Glusterfs mount on the host that shares a pod's lifetime Glusterfs *GlusterfsVolumeSource `json:"glusterfs,omitempty" description:"Glusterfs volume that will be mounted on the host machine "` // PersistentVolumeClaimVolumeSource represents a reference to a PersistentVolumeClaim in the same namespace - PersistentVolumeClaimVolumeSource *PersistentVolumeClaimVolumeSource `json:"persistentVolumeClaim,omitempty" description:"a reference to a PersistentVolumeClaim in the same namespace"` + PersistentVolumeClaim *PersistentVolumeClaimVolumeSource `json:"persistentVolumeClaim,omitempty" description:"a reference to a PersistentVolumeClaim in the same namespace"` // RBD represents a Rados Block Device mount on the host that shares a pod's lifetime RBD *RBDVolumeSource `json:"rbd,omitempty" description:"rados block volume that will be mounted on the host machine"` } diff --git a/pkg/api/validation/validation.go b/pkg/api/validation/validation.go index f953098c5e8..6fe82048a67 100644 --- a/pkg/api/validation/validation.go +++ b/pkg/api/validation/validation.go @@ -338,9 +338,9 @@ func validateSource(source *api.VolumeSource) errs.ValidationErrorList { numVolumes++ allErrs = append(allErrs, validateGlusterfs(source.Glusterfs).Prefix("glusterfs")...) } - if source.PersistentVolumeClaimVolumeSource != nil { + if source.PersistentVolumeClaim != nil { numVolumes++ - allErrs = append(allErrs, validatePersistentClaimVolumeSource(source.PersistentVolumeClaimVolumeSource).Prefix("persistentVolumeClaim")...) + allErrs = append(allErrs, validatePersistentClaimVolumeSource(source.PersistentVolumeClaim).Prefix("persistentVolumeClaim")...) } if source.RBD != nil { numVolumes++ diff --git a/pkg/volume/persistent_claim/persistent_claim.go b/pkg/volume/persistent_claim/persistent_claim.go index 77876ea696c..13757481975 100644 --- a/pkg/volume/persistent_claim/persistent_claim.go +++ b/pkg/volume/persistent_claim/persistent_claim.go @@ -48,13 +48,13 @@ func (plugin *persistentClaimPlugin) Name() string { } func (plugin *persistentClaimPlugin) CanSupport(spec *volume.Spec) bool { - return spec.VolumeSource.PersistentVolumeClaimVolumeSource != nil + return spec.VolumeSource.PersistentVolumeClaim != nil } func (plugin *persistentClaimPlugin) NewBuilder(spec *volume.Spec, pod *api.Pod, opts volume.VolumeOptions, mounter mount.Interface) (volume.Builder, error) { - claim, err := plugin.host.GetKubeClient().PersistentVolumeClaims(pod.Namespace).Get(spec.VolumeSource.PersistentVolumeClaimVolumeSource.ClaimName) + claim, err := plugin.host.GetKubeClient().PersistentVolumeClaims(pod.Namespace).Get(spec.VolumeSource.PersistentVolumeClaim.ClaimName) if err != nil { - glog.Errorf("Error finding claim: %+v\n", spec.VolumeSource.PersistentVolumeClaimVolumeSource.ClaimName) + glog.Errorf("Error finding claim: %+v\n", spec.VolumeSource.PersistentVolumeClaim.ClaimName) return nil, err } diff --git a/pkg/volume/persistent_claim/persistent_claim_test.go b/pkg/volume/persistent_claim/persistent_claim_test.go index 0eed61e4817..b18db424621 100644 --- a/pkg/volume/persistent_claim/persistent_claim_test.go +++ b/pkg/volume/persistent_claim/persistent_claim_test.go @@ -52,7 +52,7 @@ func TestCanSupport(t *testing.T) { if plug.Name() != "kubernetes.io/persistent-claim" { t.Errorf("Wrong name: %s", plug.Name()) } - if !plug.CanSupport(&volume.Spec{Name: "foo", VolumeSource: api.VolumeSource{PersistentVolumeClaimVolumeSource: &api.PersistentVolumeClaimVolumeSource{}}}) { + if !plug.CanSupport(&volume.Spec{Name: "foo", VolumeSource: api.VolumeSource{PersistentVolumeClaim: &api.PersistentVolumeClaimVolumeSource{}}}) { t.Errorf("Expected true") } if plug.CanSupport(&volume.Spec{VolumeSource: api.VolumeSource{GitRepo: &api.GitRepoVolumeSource{}}}) { @@ -99,7 +99,7 @@ func TestNewBuilder(t *testing.T) { }, }, podVolume: api.VolumeSource{ - PersistentVolumeClaimVolumeSource: &api.PersistentVolumeClaimVolumeSource{ + PersistentVolumeClaim: &api.PersistentVolumeClaimVolumeSource{ ReadOnly: false, ClaimName: "claimA", }, @@ -137,7 +137,7 @@ func TestNewBuilder(t *testing.T) { }, }, podVolume: api.VolumeSource{ - PersistentVolumeClaimVolumeSource: &api.PersistentVolumeClaimVolumeSource{ + PersistentVolumeClaim: &api.PersistentVolumeClaimVolumeSource{ ReadOnly: false, ClaimName: "claimB", }, @@ -175,7 +175,7 @@ func TestNewBuilder(t *testing.T) { }, }, podVolume: api.VolumeSource{ - PersistentVolumeClaimVolumeSource: &api.PersistentVolumeClaimVolumeSource{ + PersistentVolumeClaim: &api.PersistentVolumeClaimVolumeSource{ ReadOnly: false, ClaimName: "claimA", }, @@ -218,7 +218,7 @@ func TestNewBuilder(t *testing.T) { }, }, podVolume: api.VolumeSource{ - PersistentVolumeClaimVolumeSource: &api.PersistentVolumeClaimVolumeSource{ + PersistentVolumeClaim: &api.PersistentVolumeClaimVolumeSource{ ReadOnly: false, ClaimName: "claimA", }, @@ -287,7 +287,7 @@ func TestNewBuilderClaimNotBound(t *testing.T) { }, } podVolume := api.VolumeSource{ - PersistentVolumeClaimVolumeSource: &api.PersistentVolumeClaimVolumeSource{ + PersistentVolumeClaim: &api.PersistentVolumeClaimVolumeSource{ ReadOnly: false, ClaimName: "claimC", },