From b307321c0aebd0aa15df2978c2de0515e7ee1a46 Mon Sep 17 00:00:00 2001 From: B Aravind <89305482+aravindb26@users.noreply.github.com> Date: Wed, 14 Sep 2022 11:01:00 +0530 Subject: [PATCH] I have evaluated TODO retry remove if feasible (#112383) Hi team, hope u all doing well. I have checked TODO that to remove "retry" if feasible but it's important i think that it shouldn't be removed because it was used in every file on your repo. Update idempotency.go Update idempotency.go Update idempotency.go --- cmd/kubeadm/app/util/apiclient/idempotency.go | 2 -- 1 file changed, 2 deletions(-) diff --git a/cmd/kubeadm/app/util/apiclient/idempotency.go b/cmd/kubeadm/app/util/apiclient/idempotency.go index 978d7423731..c996d553453 100644 --- a/cmd/kubeadm/app/util/apiclient/idempotency.go +++ b/cmd/kubeadm/app/util/apiclient/idempotency.go @@ -341,8 +341,6 @@ func PatchNode(client clientset.Interface, nodeName string, patchFn func(*v1.Nod // GetConfigMapWithRetry tries to retrieve a ConfigMap using the given client, // retrying if we get an unexpected error. -// -// TODO: evaluate if this can be done better. Potentially remove the retry if feasible. func GetConfigMapWithRetry(client clientset.Interface, namespace, name string) (*v1.ConfigMap, error) { var cm *v1.ConfigMap var lastError error