Fix golint failures related to docs

This commit is contained in:
Andrea Nodari 2019-05-20 15:26:52 +02:00
parent 35f6ad187b
commit b31f5c7233
3 changed files with 15 additions and 5 deletions

View File

@ -54,22 +54,28 @@ import (
) )
const ( const (
// PodStartupLatencyThreshold holds the latency threashold for pod startup
PodStartupLatencyThreshold = 5 * time.Second PodStartupLatencyThreshold = 5 * time.Second
MinSaturationThreshold = 2 * time.Minute // MinSaturationThreshold holds the minimum staturation threashold
MinSaturationThreshold = 2 * time.Minute
// MinPodsPerSecondThroughput holds the minimum pod/sec throughput
MinPodsPerSecondThroughput = 8 MinPodsPerSecondThroughput = 8
DensityPollInterval = 10 * time.Second // DensityPollInterval holds the desity of polling interval
MinPodStartupMeasurements = 500 DensityPollInterval = 10 * time.Second
// MinPodStartupMeasurements holds the minimum number of measurements related to pod-startup
MinPodStartupMeasurements = 500
) )
// Maximum container failures this test tolerates before failing. // MaxContainerFailures holds the maximum container failures this test tolerates before failing.
var MaxContainerFailures = 0 var MaxContainerFailures = 0
// Maximum no. of missing measurements related to pod-startup that the test tolerates. // MaxMissingPodStartupMeasurements holds the maximum number of missing measurements related to pod-startup that the test tolerates.
var MaxMissingPodStartupMeasurements = 0 var MaxMissingPodStartupMeasurements = 0
// Number of nodes in the cluster (computed inside BeforeEach). // Number of nodes in the cluster (computed inside BeforeEach).
var nodeCount = 0 var nodeCount = 0
// DensityTestConfig holds the configurations for e2e scalability tests
type DensityTestConfig struct { type DensityTestConfig struct {
Configs []testutils.RunObjectConfig Configs []testutils.RunObjectConfig
ClientSets []clientset.Interface ClientSets []clientset.Interface

View File

@ -18,6 +18,7 @@ package scalability
import "github.com/onsi/ginkgo" import "github.com/onsi/ginkgo"
// SIGDescribe is the entry point for the sig-scalability e2e framework
func SIGDescribe(text string, body func()) bool { func SIGDescribe(text string, body func()) bool {
return ginkgo.Describe("[sig-scalability] "+text, body) return ginkgo.Describe("[sig-scalability] "+text, body)
} }

View File

@ -489,6 +489,7 @@ func generateConfigs(
return configs, secretConfigs, configMapConfigs return configs, secretConfigs, configMapConfigs
} }
// GenerateConfigsForGroup generates the configuration needed for a group
func GenerateConfigsForGroup( func GenerateConfigsForGroup(
nss []*v1.Namespace, nss []*v1.Namespace,
groupName string, groupName string,
@ -720,6 +721,7 @@ func deleteResource(wg *sync.WaitGroup, config testutils.RunObjectConfig, deleti
fmt.Sprintf("deleting %v %s", config.GetKind(), config.GetName())) fmt.Sprintf("deleting %v %s", config.GetKind(), config.GetName()))
} }
// CreateNamespaces creates a namespace
func CreateNamespaces(f *framework.Framework, namespaceCount int, namePrefix string, testPhase *timer.Phase) ([]*v1.Namespace, error) { func CreateNamespaces(f *framework.Framework, namespaceCount int, namePrefix string, testPhase *timer.Phase) ([]*v1.Namespace, error) {
defer testPhase.End() defer testPhase.End()
namespaces := []*v1.Namespace{} namespaces := []*v1.Namespace{}
@ -733,6 +735,7 @@ func CreateNamespaces(f *framework.Framework, namespaceCount int, namePrefix str
return namespaces, nil return namespaces, nil
} }
// CreateQuotas creates quotas
func CreateQuotas(f *framework.Framework, namespaces []*v1.Namespace, podCount int, testPhase *timer.Phase) error { func CreateQuotas(f *framework.Framework, namespaces []*v1.Namespace, podCount int, testPhase *timer.Phase) error {
defer testPhase.End() defer testPhase.End()
quotaTemplate := &v1.ResourceQuota{ quotaTemplate := &v1.ResourceQuota{