From b3249a1b39e57b7cf6a21444892ed0fb927ad17e Mon Sep 17 00:00:00 2001 From: Jan Chaloupka Date: Thu, 23 Sep 2021 13:08:02 +0200 Subject: [PATCH] e2e scheduling priorities: do not reference control loop variable Otherwise, nodeNameToPodList[nodeName] list will have all its references identical (corresponding to the control variable reference). Thus, making all the pods in the list identical. --- test/e2e/scheduling/priorities.go | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/test/e2e/scheduling/priorities.go b/test/e2e/scheduling/priorities.go index 05296a15582..a5767bfe47a 100644 --- a/test/e2e/scheduling/priorities.go +++ b/test/e2e/scheduling/priorities.go @@ -485,9 +485,9 @@ func podListForEachNode(cs clientset.Interface) map[string][]*v1.Pod { if err != nil { framework.Failf("Expect error of invalid, got : %v", err) } - for _, pod := range allPods.Items { + for i, pod := range allPods.Items { nodeName := pod.Spec.NodeName - nodeNameToPodList[nodeName] = append(nodeNameToPodList[nodeName], &pod) + nodeNameToPodList[nodeName] = append(nodeNameToPodList[nodeName], &allPods.Items[i]) } return nodeNameToPodList }