github/kubernetes
1
0
Fork 0
mirror of https://github.com/k3s-io/kubernetes.git synced 2025-08-09 03:57:41 +00:00
Code Issues Projects Releases Wiki Activity

Fix last run-in-gopath user: typecheck

Browse Source 
This now works across modules

Verified by introducing errors in 2 different modules and running.
This commit is contained in:
Tim Hockin 2023-12-29 10:27:14 -08:00
parent 91efe7e571
commit b32e207256
No known key found for this signature in database
1 changed files with 5 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
hack/verify-typecheck.sh
View File

@ -23,18 +23,15 @@ set -o pipefail
KUBE_ROOT=$(dirname "${BASH_SOURCE[0]}")/.. KUBE_ROOT=$(dirname "${BASH_SOURCE[0]}")/..
source "${KUBE_ROOT}/hack/lib/init.sh" source "${KUBE_ROOT}/hack/lib/init.sh"
kube::golang::verify_go_version
cd "${KUBE_ROOT}" cd "${KUBE_ROOT}"
# As of June, 2020 the typecheck tool is written in terms of go/packages, but kube::golang::new::setup_env
# that library doesn't work well with multiple modules. Until that is done, kube::golang::verify_go_version
# force this tooling to run in a fake GOPATH.
ret=0 ret=0
TYPECHECK_SERIAL="${TYPECHECK_SERIAL:-false}" TYPECHECK_SERIAL="${TYPECHECK_SERIAL:-false}"
hack/run-in-gopath.sh \ go run ./test/typecheck "$@" "--serial=$TYPECHECK_SERIAL" || ret=$?
go run test/typecheck/main.go "$@" "--serial=$TYPECHECK_SERIAL" || ret=$?
if [[ $ret -ne 0 ]]; then if [[ $ret -ne 0 ]]; then
echo "!!! Type Check has failed. This may cause cross platform build failures." >&2 echo "!!! Type Check has failed. This may cause cross platform build failures." >&2
echo "!!! Please see https://git.k8s.io/kubernetes/test/typecheck for more information." >&2 echo "!!! Please see https://git.k8s.io/kubernetes/test/typecheck for more information." >&2