From b3419e0ccf89a2830e49f6dbddf26fad43f8422d Mon Sep 17 00:00:00 2001 From: Andrew Sy Kim Date: Mon, 11 May 2020 12:50:50 -0400 Subject: [PATCH] service controller: remove duplicate unit test TestGetNodePredicate (Test_getNodeConditionPredicate already exists) Signed-off-by: Andrew Sy Kim --- pkg/controller/service/controller_test.go | 44 ----------------------- 1 file changed, 44 deletions(-) diff --git a/pkg/controller/service/controller_test.go b/pkg/controller/service/controller_test.go index 38c8c7860df..69ef5c72a7d 100644 --- a/pkg/controller/service/controller_test.go +++ b/pkg/controller/service/controller_test.go @@ -475,50 +475,6 @@ func TestUpdateNodesInExternalLoadBalancer(t *testing.T) { } } -func TestGetNodeConditionPredicate(t *testing.T) { - tests := []struct { - node v1.Node - expectAccept bool - name string - }{ - { - node: v1.Node{}, - expectAccept: false, - name: "empty", - }, - { - node: v1.Node{ - Status: v1.NodeStatus{ - Conditions: []v1.NodeCondition{ - {Type: v1.NodeReady, Status: v1.ConditionTrue}, - }, - }, - }, - expectAccept: true, - name: "basic", - }, - { - node: v1.Node{ - Spec: v1.NodeSpec{Unschedulable: true}, - Status: v1.NodeStatus{ - Conditions: []v1.NodeCondition{ - {Type: v1.NodeReady, Status: v1.ConditionTrue}, - }, - }, - }, - expectAccept: false, - name: "unschedulable", - }, - } - pred := getNodeConditionPredicate() - for _, test := range tests { - accept := pred(&test.node) - if accept != test.expectAccept { - t.Errorf("Test failed for %s, expected %v, saw %v", test.name, test.expectAccept, accept) - } - } -} - func TestProcessServiceCreateOrUpdate(t *testing.T) { controller, _, client := newController()