From b39e56b475a03d504f291c7dcbf7da28f19ee9bf Mon Sep 17 00:00:00 2001 From: Patrick Ohly Date: Wed, 2 Nov 2022 14:57:54 +0100 Subject: [PATCH] e2e: fix ginkgo-e2e.sh with no arguments If the script was called with no arguments, it passed "${@:-}" to the suite, which expands to one empty argument. That's not right, "${@}" should be used instead because it expands to nothing when empty. --- hack/ginkgo-e2e.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hack/ginkgo-e2e.sh b/hack/ginkgo-e2e.sh index 7814433d200..64914ea4006 100755 --- a/hack/ginkgo-e2e.sh +++ b/hack/ginkgo-e2e.sh @@ -230,4 +230,4 @@ case "${GINKGO_SHOW_COMMAND:-${CI:-no}}" in y|yes|true) set -x ;; esac ${E2E_REPORT_DIR:+"--report-dir=${E2E_REPORT_DIR}"} \ ${E2E_REPORT_PREFIX:+"--report-prefix=${E2E_REPORT_PREFIX}"} \ "${suite_args[@]:+${suite_args[@]}}" \ - "${@:-}" + "${@}"