From cd5db9b7f23b0156bf5535fc0124361fbef0ce6a Mon Sep 17 00:00:00 2001 From: Monis Khan Date: Thu, 12 Oct 2023 19:13:07 -0400 Subject: [PATCH] Skip TestUnauthenticatedHTTP2ClientConnectionClose http1 tests These occasionally flake on CI: https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/121200/pull-kubernetes-unit-go-compatibility/1712589824344461312 === Failed === FAIL: vendor/k8s.io/apiserver/pkg/endpoints/filters TestUnauthenticatedHTTP2ClientConnectionClose/other_skip=true/http/1.1 (0.19s) authentication_test.go:653: expect TCP connection: 1, actual: 2 --- FAIL: TestUnauthenticatedHTTP2ClientConnectionClose/other_skip=true/http/1.1 (0.19s) === FAIL: vendor/k8s.io/apiserver/pkg/endpoints/filters TestUnauthenticatedHTTP2ClientConnectionClose/other_skip=true (0.23s) --- FAIL: TestUnauthenticatedHTTP2ClientConnectionClose/other_skip=true (0.23s) === FAIL: vendor/k8s.io/apiserver/pkg/endpoints/filters TestUnauthenticatedHTTP2ClientConnectionClose (2.30s) Signed-off-by: Monis Khan --- .../apiserver/pkg/endpoints/filters/authentication_test.go | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/staging/src/k8s.io/apiserver/pkg/endpoints/filters/authentication_test.go b/staging/src/k8s.io/apiserver/pkg/endpoints/filters/authentication_test.go index 910eecb8997..7026a2961dc 100644 --- a/staging/src/k8s.io/apiserver/pkg/endpoints/filters/authentication_test.go +++ b/staging/src/k8s.io/apiserver/pkg/endpoints/filters/authentication_test.go @@ -658,9 +658,10 @@ func TestUnauthenticatedHTTP2ClientConnectionClose(t *testing.T) { f(t, http2.NextProtoTLS, tc.expectConnections) }) - t.Run("http/1.1", func(t *testing.T) { - f(t, "http/1.1", 1) - }) + // http1 connection reuse occasionally flakes on CI, skipping for now + // t.Run("http/1.1", func(t *testing.T) { + // f(t, "http/1.1", 1) + // }) }) } }