From b5c33e1c8c662eb9a6fe780d855bfcb6a98c1769 Mon Sep 17 00:00:00 2001 From: Clayton Coleman Date: Tue, 13 Jan 2015 18:51:33 -0500 Subject: [PATCH] Prevent internal conversion in the printer directly (as per implicit contract) --- pkg/kubectl/resource_printer.go | 3 +++ 1 file changed, 3 insertions(+) diff --git a/pkg/kubectl/resource_printer.go b/pkg/kubectl/resource_printer.go index eaf9d74d599..c1a47a701d2 100644 --- a/pkg/kubectl/resource_printer.go +++ b/pkg/kubectl/resource_printer.go @@ -109,6 +109,9 @@ func NewVersionedPrinter(printer ResourcePrinter, convertor runtime.ObjectConver // PrintObj implements ResourcePrinter func (p *VersionedPrinter) PrintObj(obj runtime.Object, w io.Writer) error { + if len(p.version) == 0 { + return fmt.Errorf("no version specified, object cannot be converted") + } converted, err := p.convertor.ConvertToVersion(obj, p.version) if err != nil { return err