From b5d592e7353d8163f1f99881ee2f2bc14d20d0b2 Mon Sep 17 00:00:00 2001 From: Lee Verberne Date: Sat, 3 Aug 2019 14:13:46 +0000 Subject: [PATCH] Simplify VisitContainers pattern in volumemanager populator --- .../populator/desired_state_of_world_populator.go | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/pkg/kubelet/volumemanager/populator/desired_state_of_world_populator.go b/pkg/kubelet/volumemanager/populator/desired_state_of_world_populator.go index 63cb854f46a..bf7ae114984 100644 --- a/pkg/kubelet/volumemanager/populator/desired_state_of_world_populator.go +++ b/pkg/kubelet/volumemanager/populator/desired_state_of_world_populator.go @@ -398,15 +398,12 @@ func mountedReadOnlyByPod(podVolume v1.Volume, pod *v1.Pod) bool { return true } - mountedReadOnly := true - podutil.VisitContainers(&pod.Spec, func(c *v1.Container) bool { + return podutil.VisitContainers(&pod.Spec, func(c *v1.Container) bool { if !mountedReadOnlyByContainer(podVolume.Name, c) { - mountedReadOnly = false return false } return true }) - return mountedReadOnly } func mountedReadOnlyByContainer(volumeName string, container *v1.Container) bool {