From 5c825d8a226821a6fefcca1a70507d1d4d64cd5b Mon Sep 17 00:00:00 2001 From: Akihiro Suda Date: Tue, 6 Feb 2024 23:41:33 +0900 Subject: [PATCH] core/v1: remove comment about non-existing constants `NodeReachable`, `NodeLive`, `NodeSchedulable`, and `NodeRunnable` are mentioned as "built-in set of conditions" but some of them do not exist in the current API. Updated `pkgs/apis/core/types.go` too for consistency. Signed-off-by: Akihiro Suda --- pkg/apis/core/types.go | 5 ++--- staging/src/k8s.io/api/core/v1/types.go | 3 +-- 2 files changed, 3 insertions(+), 5 deletions(-) diff --git a/pkg/apis/core/types.go b/pkg/apis/core/types.go index 55a7ac74fc8..412ecb31516 100644 --- a/pkg/apis/core/types.go +++ b/pkg/apis/core/types.go @@ -4900,9 +4900,8 @@ const ( // NodeConditionType defines node's condition type NodeConditionType string -// These are valid conditions of node. Currently, we don't have enough information to decide -// node condition. In the future, we will add more. The proposed set of conditions are: -// NodeReady, NodeReachable +// These are valid but not exhaustive conditions of node. A cloud provider may set a condition not listed here. +// Relevant events contain "NodeReady", "NodeNotReady", "NodeSchedulable", and "NodeNotSchedulable". const ( // NodeReady means kubelet is healthy and ready to accept pods. NodeReady NodeConditionType = "Ready" diff --git a/staging/src/k8s.io/api/core/v1/types.go b/staging/src/k8s.io/api/core/v1/types.go index f228a2eb7df..0c528c674a2 100644 --- a/staging/src/k8s.io/api/core/v1/types.go +++ b/staging/src/k8s.io/api/core/v1/types.go @@ -5867,8 +5867,7 @@ const ( type NodeConditionType string // These are valid but not exhaustive conditions of node. A cloud provider may set a condition not listed here. -// The built-in set of conditions are: -// NodeReachable, NodeLive, NodeReady, NodeSchedulable, NodeRunnable. +// Relevant events contain "NodeReady", "NodeNotReady", "NodeSchedulable", and "NodeNotSchedulable". const ( // NodeReady means kubelet is healthy and ready to accept pods. NodeReady NodeConditionType = "Ready"