From b70a145161e7b499e21a5522a1de949cb7e537dc Mon Sep 17 00:00:00 2001 From: Clayton Coleman Date: Tue, 29 Jul 2014 18:05:57 -0400 Subject: [PATCH] Split operations test --- pkg/apiserver/apiserver_test.go | 37 ---------------------------- pkg/apiserver/operation_test.go | 43 +++++++++++++++++++++++++++++++++ 2 files changed, 43 insertions(+), 37 deletions(-) diff --git a/pkg/apiserver/apiserver_test.go b/pkg/apiserver/apiserver_test.go index 042421effd5..57ccf0da9ba 100644 --- a/pkg/apiserver/apiserver_test.go +++ b/pkg/apiserver/apiserver_test.go @@ -536,43 +536,6 @@ func TestSyncCreateTimeout(t *testing.T) { } } -func TestOpGet(t *testing.T) { - simpleStorage := &SimpleRESTStorage{} - handler := New(map[string]RESTStorage{ - "foo": simpleStorage, - }, "/prefix/version") - server := httptest.NewServer(handler) - client := http.Client{} - - simple := Simple{ - Name: "foo", - } - data, err := api.Encode(simple) - t.Log(string(data)) - expectNoError(t, err) - request, err := http.NewRequest("POST", server.URL+"/prefix/version/foo", bytes.NewBuffer(data)) - expectNoError(t, err) - response, err := client.Do(request) - expectNoError(t, err) - if response.StatusCode != http.StatusAccepted { - t.Errorf("Unexpected response %#v", response) - } - - var itemOut api.Status - body, err := extractBody(response, &itemOut) - expectNoError(t, err) - if itemOut.Status != api.StatusWorking || itemOut.Details == "" { - t.Errorf("Unexpected status: %#v (%s)", itemOut, string(body)) - } - - req2, err := http.NewRequest("GET", server.URL+"/prefix/version/operations/"+itemOut.Details, nil) - expectNoError(t, err) - _, err = client.Do(req2) - expectNoError(t, err) - if response.StatusCode != http.StatusAccepted { - t.Errorf("Unexpected response %#v", response) - } -} func TestMinionTransport(t *testing.T) { content := string(`
kubelet.loggoogle.log
`) transport := &minionTransport{} diff --git a/pkg/apiserver/operation_test.go b/pkg/apiserver/operation_test.go index 35b06ab1547..a828dfab796 100644 --- a/pkg/apiserver/operation_test.go +++ b/pkg/apiserver/operation_test.go @@ -17,9 +17,14 @@ limitations under the License. package apiserver import ( + "bytes" + "net/http" + "net/http/httptest" "sync/atomic" "testing" "time" + + "github.com/GoogleCloudPlatform/kubernetes/pkg/api" ) func TestOperation(t *testing.T) { @@ -84,3 +89,41 @@ func TestOperation(t *testing.T) { t.Errorf("Got unexpected result: %#v", op.result) } } + +func TestOpGet(t *testing.T) { + simpleStorage := &SimpleRESTStorage{} + handler := New(map[string]RESTStorage{ + "foo": simpleStorage, + }, "/prefix/version") + server := httptest.NewServer(handler) + client := http.Client{} + + simple := Simple{ + Name: "foo", + } + data, err := api.Encode(simple) + t.Log(string(data)) + expectNoError(t, err) + request, err := http.NewRequest("POST", server.URL+"/prefix/version/foo", bytes.NewBuffer(data)) + expectNoError(t, err) + response, err := client.Do(request) + expectNoError(t, err) + if response.StatusCode != http.StatusAccepted { + t.Errorf("Unexpected response %#v", response) + } + + var itemOut api.Status + body, err := extractBody(response, &itemOut) + expectNoError(t, err) + if itemOut.Status != api.StatusWorking || itemOut.Details == "" { + t.Errorf("Unexpected status: %#v (%s)", itemOut, string(body)) + } + + req2, err := http.NewRequest("GET", server.URL+"/prefix/version/operations/"+itemOut.Details, nil) + expectNoError(t, err) + _, err = client.Do(req2) + expectNoError(t, err) + if response.StatusCode != http.StatusAccepted { + t.Errorf("Unexpected response %#v", response) + } +}