From b7630e416816885befd10e159806d5fbb1e196ab Mon Sep 17 00:00:00 2001
From: Masashi Honma <masashi.honma@gmail.com>
Date: Fri, 16 Oct 2020 08:27:50 +0900
Subject: [PATCH] test: Add service cluster IP range unit test

This PR adds trailing unit tests to check the service cluster IP range and
improves the code coverage of k8s.io/kubernetes/cmd/kube-apiserver/app from
5.7% to 6.2%.

1) Dual stack IPv4/IPv6
2) Invalid IPv4, IPv6 mask
3) missing IPv4, IPv6 mask
4) invalid IP address format

The tests 2, 3, 4 are suggsted by Antonio Ojea.
---
 cmd/kube-apiserver/app/server_test.go | 25 +++++++++++++++++++++++++
 1 file changed, 25 insertions(+)

diff --git a/cmd/kube-apiserver/app/server_test.go b/cmd/kube-apiserver/app/server_test.go
index 6cf61fc25f9..cf53239d8c6 100644
--- a/cmd/kube-apiserver/app/server_test.go
+++ b/cmd/kube-apiserver/app/server_test.go
@@ -31,7 +31,32 @@ func TestGetServiceIPAndRanges(t *testing.T) {
 		{"", "10.0.0.1", "10.0.0.0/24", "<nil>", false},
 		{"192.0.2.1/24", "192.0.2.1", "192.0.2.0/24", "<nil>", false},
 		{"192.0.2.1/24,192.168.128.0/17", "192.0.2.1", "192.0.2.0/24", "192.168.128.0/17", false},
+		// Dual stack IPv4/IPv6
+		{"192.0.2.1/24,2001:db2:1:3:4::1/112", "192.0.2.1", "192.0.2.0/24", "2001:db2:1:3:4::/112", false},
+		// Dual stack IPv6/IPv4
+		{"2001:db2:1:3:4::1/112,192.0.2.1/24", "2001:db2:1:3:4::1", "2001:db2:1:3:4::/112", "192.0.2.0/24", false},
+
 		{"192.0.2.1/30,192.168.128.0/17", "<nil>", "<nil>", "<nil>", true},
+		// Invalid ip range[0] IPv4 mask
+		{"192.0.2.1/33,192.168.128.0/17", "<nil>", "<nil>", "<nil>", true},
+		// Invalid ip range[1] IPv4 mask
+		{"192.0.2.1/24,192.168.128.0/33", "<nil>", "<nil>", "<nil>", true},
+		// Invalid ip range[0] IPv6 mask
+		{"2001:db2:1:3:4::1/129,192.0.2.1/24", "<nil>", "<nil>", "<nil>", true},
+		// Invalid ip range[1] IPv6 mask
+		{"192.0.2.1/24,2001:db2:1:3:4::1/129", "<nil>", "<nil>", "<nil>", true},
+		// Invalid ip range[0] missing IPv4 mask
+		{"192.0.2.1,192.168.128.0/17", "<nil>", "<nil>", "<nil>", true},
+		// Invalid ip range[1] missing IPv4 mask
+		{"192.0.2.1/24,192.168.128.1", "<nil>", "<nil>", "<nil>", true},
+		// Invalid ip range[0] missing IPv6 mask
+		{"2001:db2:1:3:4::1,192.0.2.1/24", "<nil>", "<nil>", "<nil>", true},
+		// Invalid ip range[1] missing IPv6 mask
+		{"192.0.2.1/24,2001:db2:1:3:4::1", "<nil>", "<nil>", "<nil>", true},
+		// Invalid ip range[0] IP address format
+		{"bad.ip.range,192.168.0.2/24", "<nil>", "<nil>", "<nil>", true},
+		// Invalid ip range[1] IP address format
+		{"192.168.0.2/24,bad.ip.range", "<nil>", "<nil>", "<nil>", true},
 	}
 
 	for _, test := range tests {