From b7e1f0bf17e238b3b75f4b932593dfadd2ca8183 Mon Sep 17 00:00:00 2001 From: Lin Yang Date: Thu, 2 Aug 2018 17:16:50 -0700 Subject: [PATCH] kubelet/cm/cpumanager: Fix unused variable "skipIfPermissionsError" The variable "skipIfPermissionsError" is not needed even when permission error happened. --- pkg/kubelet/cm/cpumanager/cpu_manager_test.go | 5 ----- 1 file changed, 5 deletions(-) diff --git a/pkg/kubelet/cm/cpumanager/cpu_manager_test.go b/pkg/kubelet/cm/cpumanager/cpu_manager_test.go index 1371ded6f16..baeb6a50809 100644 --- a/pkg/kubelet/cm/cpumanager/cpu_manager_test.go +++ b/pkg/kubelet/cm/cpumanager/cpu_manager_test.go @@ -199,7 +199,6 @@ func TestCPUManagerGenerate(t *testing.T) { isTopologyBroken bool expectedPolicy string expectedError error - skipIfPermissionsError bool }{ { description: "set none policy", @@ -218,7 +217,6 @@ func TestCPUManagerGenerate(t *testing.T) { cpuPolicyName: "static", nodeAllocatableReservation: v1.ResourceList{v1.ResourceCPU: *resource.NewQuantity(3, resource.DecimalSI)}, expectedPolicy: "static", - skipIfPermissionsError: true, }, { description: "static policy - broken topology", @@ -226,21 +224,18 @@ func TestCPUManagerGenerate(t *testing.T) { nodeAllocatableReservation: v1.ResourceList{}, isTopologyBroken: true, expectedError: fmt.Errorf("could not detect number of cpus"), - skipIfPermissionsError: true, }, { description: "static policy - broken reservation", cpuPolicyName: "static", nodeAllocatableReservation: v1.ResourceList{}, expectedError: fmt.Errorf("unable to determine reserved CPU resources for static policy"), - skipIfPermissionsError: true, }, { description: "static policy - no CPU resources", cpuPolicyName: "static", nodeAllocatableReservation: v1.ResourceList{v1.ResourceCPU: *resource.NewQuantity(0, resource.DecimalSI)}, expectedError: fmt.Errorf("the static policy requires systemreserved.cpu + kubereserved.cpu to be greater than zero"), - skipIfPermissionsError: true, }, }