From a8bd20a5af1174ce9f9a185b6d49f025a1045b03 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Pawe=C5=82=20Banaszewski?= Date: Fri, 29 Oct 2021 15:37:27 +0000 Subject: [PATCH] Changed buckets for apiserver_request_duration_seconds metric --- .../apiserver/pkg/endpoints/metrics/metrics.go | 4 ++-- .../testdata/stable-metrics-list.yaml | 18 +----------------- 2 files changed, 3 insertions(+), 19 deletions(-) diff --git a/staging/src/k8s.io/apiserver/pkg/endpoints/metrics/metrics.go b/staging/src/k8s.io/apiserver/pkg/endpoints/metrics/metrics.go index b72684a1f4b..b9c8da89472 100644 --- a/staging/src/k8s.io/apiserver/pkg/endpoints/metrics/metrics.go +++ b/staging/src/k8s.io/apiserver/pkg/endpoints/metrics/metrics.go @@ -103,8 +103,8 @@ var ( // This metric is used for verifying api call latencies SLO, // as well as tracking regressions in this aspects. // Thus we customize buckets significantly, to empower both usecases. - Buckets: []float64{0.05, 0.1, 0.15, 0.2, 0.25, 0.3, 0.35, 0.4, 0.45, 0.5, 0.6, 0.7, 0.8, 0.9, 1.0, - 1.25, 1.5, 1.75, 2.0, 2.5, 3.0, 3.5, 4.0, 4.5, 5, 6, 7, 8, 9, 10, 15, 20, 25, 30, 40, 50, 60}, + Buckets: []float64{0.05, 0.1, 0.2, 0.4, 0.6, 0.8, 1.0, 1.25, 1.5, 2, 3, + 4, 5, 6, 8, 10, 15, 20, 30, 45, 60}, StabilityLevel: compbasemetrics.STABLE, }, []string{"verb", "dry_run", "group", "version", "resource", "subresource", "scope", "component"}, diff --git a/test/instrumentation/testdata/stable-metrics-list.yaml b/test/instrumentation/testdata/stable-metrics-list.yaml index 459a0c6d1b1..27e63f81722 100644 --- a/test/instrumentation/testdata/stable-metrics-list.yaml +++ b/test/instrumentation/testdata/stable-metrics-list.yaml @@ -141,40 +141,24 @@ buckets: - 0.05 - 0.1 - - 0.15 - 0.2 - - 0.25 - - 0.3 - - 0.35 - 0.4 - - 0.45 - - 0.5 - 0.6 - - 0.7 - 0.8 - - 0.9 - 1 - 1.25 - 1.5 - - 1.75 - 2 - - 2.5 - 3 - - 3.5 - 4 - - 4.5 - 5 - 6 - - 7 - 8 - - 9 - 10 - 15 - 20 - - 25 - 30 - - 40 - - 50 + - 45 - 60 - name: apiserver_request_total help: Counter of apiserver requests broken out for each verb, dry run value, group,