From b83600de01e56eba2f4f3de98d22ef99a7e06d38 Mon Sep 17 00:00:00 2001 From: Paco Xu Date: Fri, 24 Mar 2023 17:00:11 +0800 Subject: [PATCH] fix nil pointer dereference panic for deprecated metrics --- pkg/registry/core/pod/rest/log.go | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/pkg/registry/core/pod/rest/log.go b/pkg/registry/core/pod/rest/log.go index 6ced8413670..eb872337fef 100644 --- a/pkg/registry/core/pod/rest/log.go +++ b/pkg/registry/core/pod/rest/log.go @@ -118,12 +118,7 @@ func countSkipTLSMetric(insecureSkipTLSVerifyBackend bool) { } counter.Inc() - deprecatedCounter, err := deprecatedPodLogsUsage.GetMetricWithLabelValues(usageType) - if err != nil { - utilruntime.HandleError(err) - return - } - deprecatedCounter.Inc() + deprecatedPodLogsUsage.WithLabelValues(usageType).Inc() } // NewGetOptions creates a new options object