From b91f07008cc0151547b6416a4bd4a4b11693f47a Mon Sep 17 00:00:00 2001 From: weizhichen Date: Mon, 6 Nov 2023 08:20:42 +0000 Subject: [PATCH] add ut --- .../reconciler/reconciler_test.go | 22 ++++++++++++++++--- 1 file changed, 19 insertions(+), 3 deletions(-) diff --git a/pkg/kubelet/volumemanager/reconciler/reconciler_test.go b/pkg/kubelet/volumemanager/reconciler/reconciler_test.go index 7e69ace560d..3dda3fd5eca 100644 --- a/pkg/kubelet/volumemanager/reconciler/reconciler_test.go +++ b/pkg/kubelet/volumemanager/reconciler/reconciler_test.go @@ -2326,15 +2326,31 @@ func TestSyncStates(t *testing.T) { filepath.Join("pod2uid", "volumes", "fake-plugin", "volume-name"), }, createMountPoint: true, - podInfos: []podInfo{defaultPodInfo}, + podInfos: []podInfo{ + { + podName: "pod2", + podUID: "pod2uid", + outerVolumeName: "volume-name", + innerVolumeName: "volume-name", + }, + }, verifyFunc: func(rcInstance *reconciler, fakePlugin *volumetesting.FakeVolumePlugin) error { // for pod that is deleted, volume is considered as mounted mountedPods := rcInstance.actualStateOfWorld.GetMountedVolumes() if len(mountedPods) != 1 { return fmt.Errorf("expected 1 pods to in asw got %d", len(mountedPods)) } - if types.UniquePodName("pod2uid") != mountedPods[0].PodName { - return fmt.Errorf("expected mounted pod to be %s got %s", "pod2uid", mountedPods[0].PodName) + if types.UniquePodName("pod1uid") != mountedPods[0].PodName { + return fmt.Errorf("expected mounted pod to be %s got %s", "pod1uid", mountedPods[0].PodName) + } + + // for pod that is in dsw, volume is in skippedDuringReconstruction + skippedVolumes := rcInstance.skippedDuringReconstruction + if len(skippedVolumes) != 1 { + return fmt.Errorf("expected 1 pods to in skippedDuringReconstruction got %d", len(skippedVolumes)) + } + if skippedVolumes["fake-plugin/volume-name"] == nil { + return fmt.Errorf("expected %s is in skippedDuringReconstruction, got %+v", "fake-plugin/volume-name", skippedVolumes) } return nil },