From 9377a4bf3228cb974dcf32c4ab8f43356bc8a8d5 Mon Sep 17 00:00:00 2001 From: Dan Winship Date: Mon, 17 Jul 2017 16:37:16 -0400 Subject: [PATCH] Update some tests to fall back to InternalIP if ExternalIP isn't set --- test/e2e/framework/service_util.go | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/test/e2e/framework/service_util.go b/test/e2e/framework/service_util.go index 114dececb12..300baa9f4a5 100644 --- a/test/e2e/framework/service_util.go +++ b/test/e2e/framework/service_util.go @@ -307,6 +307,10 @@ func GetNodePublicIps(c clientset.Interface) ([]string, error) { nodes := GetReadySchedulableNodesOrDie(c) ips := CollectAddresses(nodes, v1.NodeExternalIP) + if len(ips) == 0 { + // If ExternalIP isn't set, assume the test programs can reach the InternalIP + ips = CollectAddresses(nodes, v1.NodeInternalIP) + } return ips, nil }