delete redundant test para.

This commit is contained in:
zhangxiaoyu-zidif 2017-08-09 11:52:59 +08:00
parent a5b4899ae2
commit b952bb1d19

View File

@ -74,13 +74,12 @@ func newPod(podName string, label map[string]string, owner metav1.Object) *v1.Po
func TestClaimPods(t *testing.T) { func TestClaimPods(t *testing.T) {
controllerKind := schema.GroupVersionKind{} controllerKind := schema.GroupVersionKind{}
type test struct { type test struct {
name string name string
manager *PodControllerRefManager manager *PodControllerRefManager
pods []*v1.Pod pods []*v1.Pod
filters []func(*v1.Pod) bool filters []func(*v1.Pod) bool
claimed []*v1.Pod claimed []*v1.Pod
released []*v1.Pod released []*v1.Pod
expectError bool
} }
var tests = []test{ var tests = []test{
{ {
@ -178,8 +177,8 @@ func TestClaimPods(t *testing.T) {
} }
for _, test := range tests { for _, test := range tests {
claimed, err := test.manager.ClaimPods(test.pods) claimed, err := test.manager.ClaimPods(test.pods)
if test.expectError && err == nil { if err != nil {
t.Errorf("Test case `%s`, expected error but got nil", test.name) t.Errorf("Test case `%s`, unexpected error: %v", test.name, err)
} else if !reflect.DeepEqual(test.claimed, claimed) { } else if !reflect.DeepEqual(test.claimed, claimed) {
t.Errorf("Test case `%s`, claimed wrong pods. Expected %v, got %v", test.name, podToStringSlice(test.claimed), podToStringSlice(claimed)) t.Errorf("Test case `%s`, claimed wrong pods. Expected %v, got %v", test.name, podToStringSlice(test.claimed), podToStringSlice(claimed))
} }