github/kubernetes
1
0
Fork 0
mirror of https://github.com/k3s-io/kubernetes.git synced 2025-07-21 19:01:49 +00:00
Code Issues Projects Releases Wiki Activity

pkg/storage/etcd3: refactor "too large" resourceVersions

Browse Source 
When tests attempt to validate behavior in the case that a client asks
for a resource version that is "too large" for the underlying storage,
the previous implementation would simply add 1 to the latest revision
seen. This is only appropriate for storage backends that
  a) provide a continuous monotonic logical clock
  b) have no other events occurring while the test runs

For instance, when using a singe etcd backend as a shared fixture for
these tests, adding 1 to a previously-seen revision is not suffcient to
ensure that the resulting revision is "too large". By instead using the
largest possible integer value, we can be certain of this.

Signed-off-by: Steve Kuznetsov <skuznets@redhat.com>
This commit is contained in:
Steve Kuznetsov 2022-03-23 12:27:16 -08:00
parent 75b19b242c
commit b973cdc57c
No known key found for this signature in database
GPG Key ID: 8821C29EC988D9B4
1 changed files with 4 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
staging/src/k8s.io/apiserver/pkg/storage/etcd3/store_test.go
View File

@ -24,6 +24,7 @@ import (
"errors" "errors"
"fmt" "fmt"
"io/ioutil" "io/ioutil"
"math"
"os" "os"
"reflect" "reflect"
"strconv" "strconv"
@ -256,7 +257,7 @@ func TestGet(t *testing.T) {
name: "too high resource version", name: "too high resource version",
key: key, key: key,
expectRVTooLarge: true, expectRVTooLarge: true,
rv: fmt.Sprintf("%d", lastUpdatedCurrentRV+1), rv: strconv.FormatInt(math.MaxInt64, 10),
}, { // test get on non-existing item with ignoreNotFound=false }, { // test get on non-existing item with ignoreNotFound=false
name: "get non-existing", name: "get non-existing",
key: "/non-existing", key: "/non-existing",
@ -611,7 +612,7 @@ func TestGetListNonRecursive(t *testing.T) {
key: key, key: key,
pred: storage.Everything, pred: storage.Everything,
expectedOut: []*example.Pod{storedObj}, expectedOut: []*example.Pod{storedObj},
rv: fmt.Sprintf("%d", currentRV+1), rv: strconv.FormatInt(math.MaxInt64, 10),
expectRVTooLarge: true, expectRVTooLarge: true,
}, { }, {
name: "non-existing key", name: "non-existing key",
@ -1235,7 +1236,7 @@ func TestList(t *testing.T) {
{ {
name: "rejects resource version set too high", name: "rejects resource version set too high",
prefix: "/", prefix: "/",
rv: fmt.Sprintf("%d", continueRV+1), rv: strconv.FormatInt(math.MaxInt64, 10),
expectRVTooLarge: true, expectRVTooLarge: true,
}, },
{ {