github/kubernetes
1
0
Fork 0
mirror of https://github.com/k3s-io/kubernetes.git synced 2025-07-31 15:25:57 +00:00
Code Issues Projects Releases Wiki Activity

kubelet/container: Update the runtime interface.

Browse Source 
Make some of them (RunInContainer, ExecInContainer, etc) to have
same function signatures as current docker and rkt implementation.
This commit is contained in:
Yifan Gu 2015-04-28 16:20:11 -07:00
parent 44e7109341
commit ba1389de3c
1 changed files with 8 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
pkg/kubelet/container/runtime.go
View File

@ -54,22 +54,24 @@ type Runtime interface {
KillContainerInPod(api.Container, *api.Pod) error KillContainerInPod(api.Container, *api.Pod) error
// GetPodStatus retrieves the status of the pod, including the information of // GetPodStatus retrieves the status of the pod, including the information of
// all containers in the pod. // all containers in the pod.
GetPodStatus(*Pod) (api.PodStatus, error) GetPodStatus(*api.Pod) (api.PodStatus, error)
// GetContainers returns all containers on the node, including those are // GetContainers returns all containers on the node, including those are
// not managed by kubelet. If 'all' is false, then only running containers // not managed by kubelet. If 'all' is false, then only running containers
// are returned. // are returned.
GetContainers(all bool) ([]*Container, error) GetContainers(all bool) ([]*Container, error)
// TODO(vmarmol): Merge RunInContainer and ExecInContainer. // TODO(vmarmol): Merge RunInContainer and ExecInContainer.
// Runs the command in the container of the specified pod using nsinit. // Runs the command in the container of the specified pod using nsinit.
RunInContainer(container api.Container, pod *api.Pod, cmd []string) // TODO(yifan): Use strong type for containerID.
RunInContainer(containerID string, cmd []string) error
// Runs the command in the container of the specified pod using nsenter. // Runs the command in the container of the specified pod using nsenter.
// Attaches the processes stdin, stdout, and stderr. Optionally uses a // Attaches the processes stdin, stdout, and stderr. Optionally uses a
// tty. // tty.
ExecInContainer(container api.Container, pod *api.Pod, stdin io.Reader, stdout, stderr io.WriteCloser, tty bool) // TODO(yifan): Use strong type for containerID.
ExecInContainer(containerID string, cmd []string, stdin io.Reader, stdout, stderr io.WriteCloser, tty bool) error
// Forward the specified port from the specified pod to the stream. // Forward the specified port from the specified pod to the stream.
PortForward(pod Pod, port uint16, stream io.ReadWriteCloser) PortForward(pod Pod, port uint16, stream io.ReadWriteCloser) error
// Pull pulls an image from the network to local storage. // PullImage pulls an image from the network to local storage.
Pull(image string) PullImage(image string) error
// IsImagePresent checks whether the container image is already in the local storage. // IsImagePresent checks whether the container image is already in the local storage.
IsImagePresent(image string) (bool, error) IsImagePresent(image string) (bool, error)
} }