From ba3bab99cac3c3611a63f2c07ef3ae1002a900ba Mon Sep 17 00:00:00 2001 From: hangaoshuai Date: Thu, 1 Mar 2018 10:35:25 +0800 Subject: [PATCH] log an error message when imageToRuntimeAPIImage failed --- pkg/kubelet/dockershim/docker_image.go | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/pkg/kubelet/dockershim/docker_image.go b/pkg/kubelet/dockershim/docker_image.go index a81c9d76319..b392b13b64c 100644 --- a/pkg/kubelet/dockershim/docker_image.go +++ b/pkg/kubelet/dockershim/docker_image.go @@ -25,6 +25,7 @@ import ( "github.com/docker/docker/pkg/jsonmessage" "golang.org/x/net/context" + "github.com/golang/glog" runtimeapi "k8s.io/kubernetes/pkg/kubelet/apis/cri/runtime/v1alpha2" "k8s.io/kubernetes/pkg/kubelet/dockershim/libdocker" ) @@ -51,7 +52,7 @@ func (ds *dockerService) ListImages(_ context.Context, r *runtimeapi.ListImagesR for _, i := range images { apiImage, err := imageToRuntimeAPIImage(&i) if err != nil { - // TODO: log an error message? + glog.V(5).Infof("Failed to convert docker API image %+v to runtime API image: %v", i, err) continue } result = append(result, apiImage)