github/kubernetes
1
0
Fork 0
mirror of https://github.com/k3s-io/kubernetes.git synced 2025-07-25 12:43:23 +00:00
Code Issues Projects Releases Wiki Activity

Merge pull request #50777 from apelisse/useful-error

Browse Source 
Automatic merge from submit-queue (batch tested with PRs 49342, 50581, 50777)

apimachinery: Print unknown transport type

The current error message prints a pointer value rather than the actual
type, which is really not useful.

e.g.:

```
# Old:
unknown transport type: &{0xc42044a7b0 0xc4208d6dc0}

# New:
unknown transport type: *gcp.conditionalTransport
```

**What this PR does / why we need it**: Makes an error message more useful.

**Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: related to #50775 

**Special notes for your reviewer**:

**Release note**:

```release-note
NONE
```
This commit is contained in:
Kubernetes Submit Queue 2017-08-16 23:08:17 -07:00 committed by GitHub
commit baa6b2ff20
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
staging/src/k8s.io/apimachinery/pkg/util/net/http.go
View File

@ -108,7 +108,7 @@ func DialerFor(transport http.RoundTripper) (DialFunc, error) {
case RoundTripperWrapper:
return DialerFor(transport.WrappedRoundTripper())
default:
return nil, fmt.Errorf("unknown transport type: %v", transport)
return nil, fmt.Errorf("unknown transport type: %T", transport)
}
}
@ -129,7 +129,7 @@ func TLSClientConfig(transport http.RoundTripper) (*tls.Config, error) {
case RoundTripperWrapper:
return TLSClientConfig(transport.WrappedRoundTripper())
default:
return nil, fmt.Errorf("unknown transport type: %v", transport)
return nil, fmt.Errorf("unknown transport type: %T", transport)
}
}