github/kubernetes
1
0
Fork 0
mirror of https://github.com/k3s-io/kubernetes.git synced 2025-08-12 05:21:58 +00:00
Code Issues Projects Releases Wiki Activity

Merge pull request #118150 from neolit123/1.28-fix-pointer-comp-test

Browse Source 
kubeadm: remove function pointer comparison in phase test
This commit is contained in:
Kubernetes Prow Robot 2023-05-20 23:10:18 -07:00 committed by GitHub
commit badcf9ab46
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 0 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
cmd/kubeadm/app/cmd/phases/workflow/runner_test.go
View File

@ -401,14 +401,8 @@ func TestBindToCommandArgRequirements(t *testing.T) {
continue continue
} }
// Ensure it is the expected function
if reflect.ValueOf(cCmd.Args).Pointer() != reflect.ValueOf(args.args).Pointer() {
t.Error("The function pointers where not equal.")
}
// Test passing argument set // Test passing argument set
err := cCmd.Args(cCmd, args.pass) err := cCmd.Args(cCmd, args.pass)
if err != nil { if err != nil {
t.Errorf("command %s should validate the args: %v\n %v", cCmd.Name(), args.pass, err) t.Errorf("command %s should validate the args: %v\n %v", cCmd.Name(), args.pass, err)
} }