From baf091e9dbad00db39e246815f9d7a21d148044f Mon Sep 17 00:00:00 2001 From: Clayton Coleman Date: Wed, 3 Apr 2019 12:12:11 -0400 Subject: [PATCH] Fake ObjectReaction should handle PartialObjectMetadata special When a client requests a PartialObjectMetadata returned from the ObjectReaction type, if the object has a GVK set use that instead of what the schema returns, since the majority of clients getting partial object metadata will be doing so using the metadata client or server side conversion. --- staging/src/k8s.io/client-go/testing/fixture.go | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/staging/src/k8s.io/client-go/testing/fixture.go b/staging/src/k8s.io/client-go/testing/fixture.go index b3ace307f83..98f82326730 100644 --- a/staging/src/k8s.io/client-go/testing/fixture.go +++ b/staging/src/k8s.io/client-go/testing/fixture.go @@ -318,6 +318,11 @@ func (t *tracker) Add(obj runtime.Object) error { if err != nil { return err } + + if partial, ok := obj.(*metav1.PartialObjectMetadata); ok && len(partial.TypeMeta.APIVersion) > 0 { + gvks = []schema.GroupVersionKind{partial.TypeMeta.GroupVersionKind()} + } + if len(gvks) == 0 { return fmt.Errorf("no registered kinds for %v", obj) }