github/kubernetes
1
0
Fork 0
mirror of https://github.com/k3s-io/kubernetes.git synced 2025-07-31 15:25:57 +00:00
Code Issues Projects Releases Wiki Activity

Small cleanup in metrics

Browse Source
This commit is contained in:
Wojciech Tyczynski 2016-02-10 16:05:52 +01:00
parent ac401a27f7
commit bb79ed6f8e
2 changed files with 7 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
pkg/apiserver/metrics/metrics.go
View File

@ -66,10 +66,11 @@ func Register() {
prometheus.MustRegister(requestLatenciesSummary) prometheus.MustRegister(requestLatenciesSummary)
} }
func Monitor(verb, resource *string, client string, httpCode *int, reqStart time.Time) { func Monitor(verb, resource *string, client string, httpCode int, reqStart time.Time) {
requestCounter.WithLabelValues(*verb, *resource, client, codeToString(*httpCode)).Inc() elapsed := float64((time.Since(reqStart)) / time.Microsecond)
requestLatencies.WithLabelValues(*verb, *resource).Observe(float64((time.Since(reqStart)) / time.Microsecond)) requestCounter.WithLabelValues(*verb, *resource, client, codeToString(httpCode)).Inc()
requestLatenciesSummary.WithLabelValues(*verb, *resource).Observe(float64((time.Since(reqStart)) / time.Microsecond)) requestLatencies.WithLabelValues(*verb, *resource).Observe(elapsed)
requestLatenciesSummary.WithLabelValues(*verb, *resource).Observe(elapsed)
} }
func Reset() { func Reset() {
@ -98,11 +99,7 @@ func InstrumentRouteFunc(verb, resource string, routeFunc restful.RouteFunction)
response.ResponseWriter = rw response.ResponseWriter = rw
routeFunc(request, response) routeFunc(request, response)
Monitor(&verb, &resource, utilnet.GetHTTPClient(request.Request), delegate.status, now)
elapsed := float64(time.Since(now)) / float64(time.Microsecond)
requestCounter.WithLabelValues(verb, resource, utilnet.GetHTTPClient(request.Request), codeToString(delegate.status)).Inc()
requestLatencies.WithLabelValues(verb, resource).Observe(elapsed)
requestLatenciesSummary.WithLabelValues(verb, resource).Observe(elapsed)
}) })
} }

2
pkg/apiserver/proxy.go
View File

@ -57,7 +57,7 @@ func (r *ProxyHandler) ServeHTTP(w http.ResponseWriter, req *http.Request) {
var apiResource string var apiResource string
var httpCode int var httpCode int
reqStart := time.Now() reqStart := time.Now()
defer metrics.Monitor(&verb, &apiResource, net.GetHTTPClient(req), &httpCode, reqStart) defer metrics.Monitor(&verb, &apiResource, net.GetHTTPClient(req), httpCode, reqStart)
requestInfo, err := r.requestInfoResolver.GetRequestInfo(req) requestInfo, err := r.requestInfoResolver.GetRequestInfo(req)
if err != nil || !requestInfo.IsResourceRequest { if err != nil || !requestInfo.IsResourceRequest {