github/kubernetes
1
0
Fork 0
mirror of https://github.com/k3s-io/kubernetes.git synced 2025-07-25 04:33:26 +00:00
Code Issues Projects Releases Wiki Activity

Svc REST: rename allocUpdateServiceClusterIPsNew

Browse Source
This commit is contained in:
Tim Hockin 2021-08-24 22:04:11 -07:00
parent 3b971b137c
commit bb815e6687
1 changed files with 2 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
pkg/registry/core/service/storage/rest.go
View File

@ -172,7 +172,7 @@ func (al *RESTAllocStuff) allocateUpdate(service, oldService *api.Service, dryRu
//TODO(thockin): validation should not pass with empty clusterIP, but it //TODO(thockin): validation should not pass with empty clusterIP, but it
//does (and is tested!). Fixing that all is a big PR and will have to //does (and is tested!). Fixing that all is a big PR and will have to
//happen later. //happen later.
if txn, err := al.allocUpdateServiceClusterIPsNew(service, oldService, dryRun); err != nil { if txn, err := al.txnUpdateClusterIPs(service, oldService, dryRun); err != nil {
result.Revert() result.Revert()
return nil, err return nil, err
} else { } else {
@ -385,8 +385,7 @@ func (al *RESTAllocStuff) allocServiceClusterIPs(service *api.Service, dryRun bo
return allocated, err return allocated, err
} }
//FIXME: rename and merge with handleClusterIPsForUpdatedService func (al *RESTAllocStuff) txnUpdateClusterIPs(service *api.Service, oldService *api.Service, dryRun bool) (transaction, error) {
func (al *RESTAllocStuff) allocUpdateServiceClusterIPsNew(service *api.Service, oldService *api.Service, dryRun bool) (transaction, error) {
allocated, released, err := al.handleClusterIPsForUpdatedService(oldService, service, dryRun) allocated, released, err := al.handleClusterIPsForUpdatedService(oldService, service, dryRun)
if err != nil { if err != nil {
return nil, err return nil, err