From bbab0d6c5f9fe75388583772ef4f094e863f9627 Mon Sep 17 00:00:00 2001 From: Antoine Pelisse Date: Wed, 30 Jan 2019 14:15:25 -0800 Subject: [PATCH] Avoid closure --- staging/src/k8s.io/apiserver/pkg/endpoints/handlers/update.go | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/staging/src/k8s.io/apiserver/pkg/endpoints/handlers/update.go b/staging/src/k8s.io/apiserver/pkg/endpoints/handlers/update.go index 4e0c17559f6..7289d9495f1 100644 --- a/staging/src/k8s.io/apiserver/pkg/endpoints/handlers/update.go +++ b/staging/src/k8s.io/apiserver/pkg/endpoints/handlers/update.go @@ -124,7 +124,8 @@ func UpdateResource(r rest.Updater, scope RequestScope, admit admission.Interfac transformers := []rest.TransformFunc{} if scope.FieldManager != nil { transformers = append(transformers, func(_ context.Context, newObj, liveObj runtime.Object) (runtime.Object, error) { - if obj, err = scope.FieldManager.Update(liveObj, newObj, prefixFromUserAgent(req.UserAgent())); err != nil { + obj, err := scope.FieldManager.Update(liveObj, newObj, prefixFromUserAgent(req.UserAgent())) + if err != nil { return nil, fmt.Errorf("failed to update object (Update for %v) managed fields: %v", scope.Kind, err) } return obj, nil