github/kubernetes
1
0
Fork 0
mirror of https://github.com/k3s-io/kubernetes.git synced 2025-07-21 19:01:49 +00:00
Code Issues Projects Releases Wiki Activity

Merge pull request #112649 from howardjohn/set/optimize-everything-nothing

Browse Source 
Optimize `Everything` and `Nothing` label selectors
This commit is contained in:
Kubernetes Prow Robot 2022-11-02 21:39:57 -07:00 committed by GitHub
commit bbe050dd01
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 8 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
staging/src/k8s.io/apimachinery/pkg/labels/selector.go
View File

@ -74,9 +74,12 @@ type Selector interface {
RequiresExactMatch(label string) (value string, found bool) RequiresExactMatch(label string) (value string, found bool)
} }
// Sharing this saves 1 alloc per use; this is safe because it's immutable.
var sharedEverythingSelector Selector = internalSelector{}
// Everything returns a selector that matches all labels. // Everything returns a selector that matches all labels.
func Everything() Selector { func Everything() Selector {
return internalSelector{} return sharedEverythingSelector
} }
type nothingSelector struct{} type nothingSelector struct{}
@ -91,9 +94,12 @@ func (n nothingSelector) RequiresExactMatch(label string) (value string, found b
return "", false return "", false
} }
// Sharing this saves 1 alloc per use; this is safe because it's immutable.
var sharedNothingSelector Selector = nothingSelector{}
// Nothing returns a selector that matches no labels // Nothing returns a selector that matches no labels
func Nothing() Selector { func Nothing() Selector {
return nothingSelector{} return sharedNothingSelector
} }
// NewSelector returns a nil selector // NewSelector returns a nil selector