From 10f300313e53bff9932ce7b0b10bb14196fb43bd Mon Sep 17 00:00:00 2001 From: Pavithra Ramesh Date: Tue, 26 May 2020 12:08:14 -0700 Subject: [PATCH] Include unschedulable nodes to compute dns replica This change picks up the new flag added to cluster autoscaler to include unschedulable nodes when computing number of DNS replica. This fixes an issue where cordoning large nodepools can cause a big drop in the number of kube-dns replicas and cause existing workloads to see DNS outage. --- .../dns-horizontal-autoscaler/dns-horizontal-autoscaler.yaml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/cluster/addons/dns-horizontal-autoscaler/dns-horizontal-autoscaler.yaml b/cluster/addons/dns-horizontal-autoscaler/dns-horizontal-autoscaler.yaml index c0c45b54ad1..848a92e4d0d 100644 --- a/cluster/addons/dns-horizontal-autoscaler/dns-horizontal-autoscaler.yaml +++ b/cluster/addons/dns-horizontal-autoscaler/dns-horizontal-autoscaler.yaml @@ -86,7 +86,7 @@ spec: kubernetes.io/os: linux containers: - name: autoscaler - image: k8s.gcr.io/cluster-proportional-autoscaler-amd64:1.7.1 + image: k8s.gcr.io/cluster-proportional-autoscaler-amd64:1.8.0 resources: requests: cpu: "20m" @@ -99,7 +99,7 @@ spec: - --target={{.Target}} # When cluster is using large nodes(with more cores), "coresPerReplica" should dominate. # If using small nodes, "nodesPerReplica" should dominate. - - --default-params={"linear":{"coresPerReplica":256,"nodesPerReplica":16,"preventSinglePointFailure":true}} + - --default-params={"linear":{"coresPerReplica":256,"nodesPerReplica":16,"preventSinglePointFailure":true,"includeUnschedulableNodes":true}} - --logtostderr=true - --v=2 tolerations: