From bc93e7bcdeda9744b20cdd52312d028680c371da Mon Sep 17 00:00:00 2001 From: Di Xu Date: Sat, 27 May 2017 14:49:16 +0800 Subject: [PATCH] remove redundant carriage return for readable --- pkg/kubelet/volumemanager/volume_manager.go | 12 ++++-------- pkg/kubelet/volumemanager/volume_manager_test.go | 10 ++-------- 2 files changed, 6 insertions(+), 16 deletions(-) diff --git a/pkg/kubelet/volumemanager/volume_manager.go b/pkg/kubelet/volumemanager/volume_manager.go index fe39f897610..f2af6b216b8 100644 --- a/pkg/kubelet/volumemanager/volume_manager.go +++ b/pkg/kubelet/volumemanager/volume_manager.go @@ -249,8 +249,7 @@ func (vm *volumeManager) Run(sourcesReady config.SourcesReady, stopCh <-chan str glog.Infof("Shutting down Kubelet Volume Manager") } -func (vm *volumeManager) GetMountedVolumesForPod( - podName types.UniquePodName) container.VolumeMap { +func (vm *volumeManager) GetMountedVolumesForPod(podName types.UniquePodName) container.VolumeMap { podVolumes := make(container.VolumeMap) for _, mountedVolume := range vm.actualStateOfWorld.GetMountedVolumesForPod(podName) { podVolumes[mountedVolume.OuterVolumeSpecName] = container.VolumeInfo{Mounter: mountedVolume.Mounter} @@ -373,8 +372,7 @@ func (vm *volumeManager) WaitForAttachAndMount(pod *v1.Pod) error { // verifyVolumesMountedFunc returns a method that returns true when all expected // volumes are mounted. -func (vm *volumeManager) verifyVolumesMountedFunc( - podName types.UniquePodName, expectedVolumes []string) wait.ConditionFunc { +func (vm *volumeManager) verifyVolumesMountedFunc(podName types.UniquePodName, expectedVolumes []string) wait.ConditionFunc { return func() (done bool, err error) { return len(vm.getUnmountedVolumes(podName, expectedVolumes)) == 0, nil } @@ -383,8 +381,7 @@ func (vm *volumeManager) verifyVolumesMountedFunc( // getUnmountedVolumes fetches the current list of mounted volumes from // the actual state of the world, and uses it to process the list of // expectedVolumes. It returns a list of unmounted volumes. -func (vm *volumeManager) getUnmountedVolumes( - podName types.UniquePodName, expectedVolumes []string) []string { +func (vm *volumeManager) getUnmountedVolumes(podName types.UniquePodName, expectedVolumes []string) []string { mountedVolumes := sets.NewString() for _, mountedVolume := range vm.actualStateOfWorld.GetMountedVolumesForPod(podName) { mountedVolumes.Insert(mountedVolume.OuterVolumeSpecName) @@ -394,8 +391,7 @@ func (vm *volumeManager) getUnmountedVolumes( // filterUnmountedVolumes adds each element of expectedVolumes that is not in // mountedVolumes to a list of unmountedVolumes and returns it. -func filterUnmountedVolumes( - mountedVolumes sets.String, expectedVolumes []string) []string { +func filterUnmountedVolumes(mountedVolumes sets.String, expectedVolumes []string) []string { unmountedVolumes := []string{} for _, expectedVolume := range expectedVolumes { if !mountedVolumes.Has(expectedVolume) { diff --git a/pkg/kubelet/volumemanager/volume_manager_test.go b/pkg/kubelet/volumemanager/volume_manager_test.go index 290e212abba..0f523c90593 100644 --- a/pkg/kubelet/volumemanager/volume_manager_test.go +++ b/pkg/kubelet/volumemanager/volume_manager_test.go @@ -182,10 +182,7 @@ func TestGetExtraSupplementalGroupsForPod(t *testing.T) { } } -func newTestVolumeManager( - tmpDir string, - podManager pod.Manager, - kubeClient clientset.Interface) (VolumeManager, error) { +func newTestVolumeManager(tmpDir string, podManager pod.Manager, kubeClient clientset.Interface) (VolumeManager, error) { plug := &volumetest.FakeVolumePlugin{PluginName: "fake", Host: nil} fakeRecorder := &record.FakeRecorder{} plugMgr := &volume.VolumePluginMgr{} @@ -275,10 +272,7 @@ func createObjects() (*v1.Node, *v1.Pod, *v1.PersistentVolume, *v1.PersistentVol return node, pod, pv, claim } -func simulateVolumeInUseUpdate( - volumeName v1.UniqueVolumeName, - stopCh <-chan struct{}, - volumeManager VolumeManager) { +func simulateVolumeInUseUpdate(volumeName v1.UniqueVolumeName, stopCh <-chan struct{}, volumeManager VolumeManager) { ticker := time.NewTicker(100 * time.Millisecond) defer ticker.Stop() for {