github/kubernetes
1
0
Fork 0
mirror of https://github.com/k3s-io/kubernetes.git synced 2025-07-25 20:53:33 +00:00
Code Issues Projects Releases Wiki Activity

Fix e2e scheduler_predicates.go to have 10 minute timeout instead of 2

Browse Source 
minutes.

On an n1-standard-1 with only this test running, 2 minutes was enough
to create 189 pods out of the 300 desired.  On slower VMs or with more
activity on the master (such as with parallel tests), 2 minutes is
nowhere near enough.  This is a functional test, not a performance
test.
This commit is contained in:
Alex Mohr 2015-08-04 22:59:30 -07:00
parent c29c8414e1
commit bcb6e1e107
1 changed files with 13 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
test/e2e/scheduler_predicates.go
View File

@ -47,8 +47,11 @@ func startPods(c *client.Client, replicas int, ns string, podNamePrefix string,
expectNoError(err) expectNoError(err)
} }
// Wait for pods to start running. // Wait for pods to start running. Note: this is a functional
timeout := 2 * time.Minute // test, not a performance test, so the timeout needs to be
// sufficiently long that it's only triggered if things are
// completely broken vs. running slowly.
timeout := 10 * time.Minute
startTime := time.Now() startTime := time.Now()
currentlyRunningPods := 0 currentlyRunningPods := 0
for podsRunningBefore+replicas != currentlyRunningPods { for podsRunningBefore+replicas != currentlyRunningPods {
@ -61,7 +64,9 @@ func startPods(c *client.Client, replicas int, ns string, podNamePrefix string,
} }
} }
currentlyRunningPods = runningPods currentlyRunningPods = runningPods
Logf("%v pods running", currentlyRunningPods)
if startTime.Add(timeout).Before(time.Now()) { if startTime.Add(timeout).Before(time.Now()) {
Logf("Timed out after %v waiting for pods to start running.", timeout)
break break
} }
time.Sleep(5 * time.Second) time.Sleep(5 * time.Second)
@ -215,6 +220,8 @@ var _ = Describe("SchedulerPredicates", func() {
}) })
expectNoError(err) expectNoError(err)
// Wait a bit to allow scheduler to do its thing // Wait a bit to allow scheduler to do its thing
// TODO: this is brittle; there's no guarantee the scheduler will have run in 10 seconds.
Logf("Sleeping 10 seconds and crossing our fingers that scheduler will run in that time.")
time.Sleep(10 * time.Second) time.Sleep(10 * time.Second)
verifyResult(c, podName, ns) verifyResult(c, podName, ns)
@ -296,6 +303,8 @@ var _ = Describe("SchedulerPredicates", func() {
}) })
expectNoError(err) expectNoError(err)
// Wait a bit to allow scheduler to do its thing // Wait a bit to allow scheduler to do its thing
// TODO: this is brittle; there's no guarantee the scheduler will have run in 10 seconds.
Logf("Sleeping 10 seconds and crossing our fingers that scheduler will run in that time.")
time.Sleep(10 * time.Second) time.Sleep(10 * time.Second)
verifyResult(c, podName, ns) verifyResult(c, podName, ns)
@ -329,6 +338,8 @@ var _ = Describe("SchedulerPredicates", func() {
}) })
expectNoError(err) expectNoError(err)
// Wait a bit to allow scheduler to do its thing // Wait a bit to allow scheduler to do its thing
// TODO: this is brittle; there's no guarantee the scheduler will have run in 10 seconds.
Logf("Sleeping 10 seconds and crossing our fingers that scheduler will run in that time.")
time.Sleep(10 * time.Second) time.Sleep(10 * time.Second)
verifyResult(c, podName, ns) verifyResult(c, podName, ns)