From 78f7027f662a476818d53d42003a55813b6f31e4 Mon Sep 17 00:00:00 2001 From: Onur Satici Date: Fri, 3 May 2019 11:56:00 +0100 Subject: [PATCH 1/2] fix scheduler plugin example --- .../framework/plugins/examples/multipoint/multipoint.go | 1 + 1 file changed, 1 insertion(+) diff --git a/pkg/scheduler/framework/plugins/examples/multipoint/multipoint.go b/pkg/scheduler/framework/plugins/examples/multipoint/multipoint.go index bf2d6131cef..8fbc8f6af14 100644 --- a/pkg/scheduler/framework/plugins/examples/multipoint/multipoint.go +++ b/pkg/scheduler/framework/plugins/examples/multipoint/multipoint.go @@ -27,6 +27,7 @@ import ( type CommunicatingPlugin struct{} var _ = framework.ReservePlugin(CommunicatingPlugin{}) +var _ = framework.PrebindPlugin(CommunicatingPlugin{}) // Name is the name of the plug used in Registry and configurations. const Name = "multipoint-communicating-plugin" From 1fccb933c6f82b09ff0a128656bd94730320af33 Mon Sep 17 00:00:00 2001 From: Onur Satici Date: Fri, 3 May 2019 21:05:52 +0100 Subject: [PATCH 2/2] make example plugins conform with the PluginFactory type --- .../framework/plugins/examples/multipoint/multipoint.go | 2 +- pkg/scheduler/framework/plugins/examples/prebind/prebind.go | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/pkg/scheduler/framework/plugins/examples/multipoint/multipoint.go b/pkg/scheduler/framework/plugins/examples/multipoint/multipoint.go index 8fbc8f6af14..c927c34ccc7 100644 --- a/pkg/scheduler/framework/plugins/examples/multipoint/multipoint.go +++ b/pkg/scheduler/framework/plugins/examples/multipoint/multipoint.go @@ -64,6 +64,6 @@ func (mc CommunicatingPlugin) Prebind(pc *framework.PluginContext, pod *v1.Pod, } // New initializes a new plugin and returns it. -func New(_ *runtime.Unknown, _ framework.Framework) (framework.Plugin, error) { +func New(_ *runtime.Unknown, _ framework.FrameworkHandle) (framework.Plugin, error) { return &CommunicatingPlugin{}, nil } diff --git a/pkg/scheduler/framework/plugins/examples/prebind/prebind.go b/pkg/scheduler/framework/plugins/examples/prebind/prebind.go index cb7217447e8..71b58127275 100644 --- a/pkg/scheduler/framework/plugins/examples/prebind/prebind.go +++ b/pkg/scheduler/framework/plugins/examples/prebind/prebind.go @@ -50,6 +50,6 @@ func (sr StatelessPrebindExample) Prebind(pc *framework.PluginContext, pod *v1.P } // New initializes a new plugin and returns it. -func New(_ *runtime.Unknown, _ framework.Framework) (framework.Plugin, error) { +func New(_ *runtime.Unknown, _ framework.FrameworkHandle) (framework.Plugin, error) { return &StatelessPrebindExample{}, nil }