From bd65a9ca26d0d61feca8931fa9a05088d10b9f23 Mon Sep 17 00:00:00 2001 From: Antonio Ojea Date: Mon, 3 Jun 2019 23:58:52 +0200 Subject: [PATCH] Fix verify-shellcheck comments Replace "files" instead of packages in the script hack/verify-shellcheck.sh --- hack/verify-shellcheck.sh | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/hack/verify-shellcheck.sh b/hack/verify-shellcheck.sh index 8ae836d0551..39bc6a1c92a 100755 --- a/hack/verify-shellcheck.sh +++ b/hack/verify-shellcheck.sh @@ -163,7 +163,7 @@ for f in "${all_shell_scripts[@]}"; do fi done -# Check to be sure all the packages that should pass lint are. +# Check to be sure all the files that should pass lint are. if [ ${#errors[@]} -eq 0 ]; then echo 'Congratulations! All shell files are passing lint (excluding those in hack/.shellcheck_failures).' else @@ -183,7 +183,7 @@ fi if [[ ${#not_failing[@]} -gt 0 ]]; then { - echo "Some packages in hack/.shellcheck_failures are passing shellcheck. Please remove them." + echo "Some files in hack/.shellcheck_failures are passing shellcheck. Please remove them." echo for f in "${not_failing[@]}"; do echo " $f" @@ -193,7 +193,7 @@ if [[ ${#not_failing[@]} -gt 0 ]]; then exit 1 fi -# Check that all failing_packages actually still exist +# Check that all failing_files actually still exist gone=() for f in "${failing_files[@]}"; do kube::util::array_contains "$f" "${all_shell_scripts[@]}" || gone+=( "$f" )